From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752515AbcAGIZM (ORCPT ); Thu, 7 Jan 2016 03:25:12 -0500 Received: from e06smtp17.uk.ibm.com ([195.75.94.113]:45196 "EHLO e06smtp17.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbcAGIZK (ORCPT ); Thu, 7 Jan 2016 03:25:10 -0500 X-IBM-Helo: d06dlp02.portsmouth.uk.ibm.com X-IBM-MailFrom: borntraeger@de.ibm.com X-IBM-RcptTo: kvm@vger.kernel.org;linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Subject: Re: [PATCH] kvm/s390: drop unpaired smp_mb To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org References: <1452010811-25486-1-git-send-email-mst@redhat.com> Cc: Gleb Natapov , Paolo Bonzini , Cornelia Huck , Martin Schwidefsky , Heiko Carstens , kvm@vger.kernel.org, linux-s390@vger.kernel.org From: Christian Borntraeger Message-ID: <568E20DF.6090402@de.ibm.com> Date: Thu, 7 Jan 2016 09:25:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1452010811-25486-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16010708-0005-0000-0000-000009EDF7FF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/2016 05:20 PM, Michael S. Tsirkin wrote: > smp_mb on vcpu destroy isn't paired with anything, violating pairing > rules, and seems to be useless. > > Drop it. > > Signed-off-by: Michael S. Tsirkin Applied. (I had to fix this up a little to match kvm/next) Thanks > --- > > Untested. > > arch/s390/kvm/kvm-s390.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c > index 8465892..7305d2c 100644 > --- a/arch/s390/kvm/kvm-s390.c > +++ b/arch/s390/kvm/kvm-s390.c > @@ -1195,7 +1195,6 @@ void kvm_arch_vcpu_destroy(struct kvm_vcpu *vcpu) > (__u64) vcpu->arch.sie_block) > vcpu->kvm->arch.sca->cpu[vcpu->vcpu_id].sda = 0; > } > - smp_mb(); > > if (kvm_is_ucontrol(vcpu->kvm)) > gmap_free(vcpu->arch.gmap); >