From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752685AbcAGIlp (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 Jan 2016 03:41:45 -0500
Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:36138 "EHLO
	e06smtp15.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751936AbcAGIln (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Jan 2016 03:41:43 -0500
X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com
X-IBM-MailFrom: borntraeger@de.ibm.com
X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org
Subject: Re: [PATCH] s390: drop smp_mb in vdso_init
To: "Michael S. Tsirkin" <mst@redhat.com>, linux-kernel@vger.kernel.org
References: <1452010645-25380-1-git-send-email-mst@redhat.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>, linux-s390@vger.kernel.org
From: Christian Borntraeger <borntraeger@de.ibm.com>
Message-ID: <568E24C1.7090109@de.ibm.com>
Date: Thu, 7 Jan 2016 09:41:37 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <1452010645-25380-1-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-TM-AS-MML: disable
X-Content-Scanned: Fidelis XPS MAILER
x-cbid: 16010708-0021-0000-0000-000008801953
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/05/2016 05:17 PM, Michael S. Tsirkin wrote:
> The initial s390 vdso code is heavily influenced by the powerpc version
> which does have a smp_wmb in vdso_init right before the vdso_ready=1
> assignment. s390 has no need for that.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> 
> Untested.
> 
>  arch/s390/kernel/vdso.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/s390/kernel/vdso.c b/arch/s390/kernel/vdso.c
> index 59eddb0..a1cfd37 100644
> --- a/arch/s390/kernel/vdso.c
> +++ b/arch/s390/kernel/vdso.c
> @@ -299,8 +299,6 @@ static int __init vdso_init(void)
> 
>  	get_page(virt_to_page(vdso_data));
> 
> -	smp_mb();
> -
>  	return 0;
>  }
>  early_initcall(vdso_init);
> 

applied to the s390 tree.
Thanks.