From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753177AbcAGKH2 (ORCPT ); Thu, 7 Jan 2016 05:07:28 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:35209 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753096AbcAGKHR (ORCPT ); Thu, 7 Jan 2016 05:07:17 -0500 Subject: Re: [PATCH 1/4] KVM: use list_for_each_entry_safe To: Geliang Tang , Gleb Natapov , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" References: Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: <568E38CB.3010604@redhat.com> Date: Thu, 7 Jan 2016 11:07:07 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/01/2016 12:47, Geliang Tang wrote: > Use list_for_each_entry_safe() instead of list_for_each_safe() to > simplify the code. > > Signed-off-by: Geliang Tang > --- > virt/kvm/kvm_main.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 484079e..5b6df4f 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -630,13 +630,10 @@ void *kvm_kvzalloc(unsigned long size) > > static void kvm_destroy_devices(struct kvm *kvm) > { > - struct list_head *node, *tmp; > + struct kvm_device *dev, *tmp; > > - list_for_each_safe(node, tmp, &kvm->devices) { > - struct kvm_device *dev = > - list_entry(node, struct kvm_device, vm_node); > - > - list_del(node); > + list_for_each_entry_safe(dev, tmp, &kvm->devices, vm_node) { > + list_del(&dev->vm_node); > dev->ops->destroy(dev); > } > } > These patches will be considered for 4.6. Thanks! Paolo