From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753065AbcAGKHu (ORCPT ); Thu, 7 Jan 2016 05:07:50 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:35644 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752018AbcAGKHn (ORCPT ); Thu, 7 Jan 2016 05:07:43 -0500 Subject: Re: [PATCH RESEND] kvm:x86:Make sure kvm_write_guest successes for first call in kvm_write_wall_clock To: Nicholas Krause , gleb@kernel.org References: <1451498926-29395-1-git-send-email-xerofoify@gmail.com> Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: <568E38E7.9070502@redhat.com> Date: Thu, 7 Jan 2016 11:07:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1451498926-29395-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/12/2015 19:08, Nicholas Krause wrote: > This makes sure that kvm_write_guest successes for the first call > in order to make sure that the wall clock is successfully written > to the host system before being calucated as required by the > guest system. > > Signed-off-by: Nicholas Krause > --- > arch/x86/kvm/x86.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index eed3228..7551f30 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -1167,7 +1167,8 @@ static void kvm_write_wall_clock(struct kvm *kvm, gpa_t wall_clock) > > ++version; > > - kvm_write_guest(kvm, wall_clock, &version, sizeof(version)); > + if (kvm_write_guest(kvm, wall_clock, &version, sizeof(version))) > + return; > > /* > * The guest calculates current wall clock time by adding > Applied, thanks. Paolo