From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753551AbcAGU4Z (ORCPT ); Thu, 7 Jan 2016 15:56:25 -0500 Received: from lists.s-osg.org ([54.187.51.154]:47201 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752356AbcAGU4X (ORCPT ); Thu, 7 Jan 2016 15:56:23 -0500 Subject: Re: [PATCH v2 3/5] test: firmware_class: add asynchronous request trigger To: Brian Norris , Greg Kroah-Hartman , Ming Lei References: <1449701429-121423-1-git-send-email-computersforpeace@gmail.com> <1449701429-121423-3-git-send-email-computersforpeace@gmail.com> Cc: Kees Cook , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, "Luis R. Rodriguez" , Shuah Khan From: Shuah Khan Organization: Samsung Open Source Group Message-ID: <568ED0F6.5090701@osg.samsung.com> Date: Thu, 7 Jan 2016 13:56:22 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1449701429-121423-3-git-send-email-computersforpeace@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/09/2015 03:50 PM, Brian Norris wrote: > We might want to test for bugs like that found in commit f9692b2699bd > ("firmware: fix possible use after free on name on asynchronous > request"), where the asynchronous request API had race conditions. > > Let's add a simple file that will launch the async request, then wait > until it's complete and report the status. It's not a true async test > (we're using a mutex + wait_for_completion(), so we can't get more than > one going at the same time), but it does help make sure the basic API is > sane, and it can catch some class of bugs. > > Signed-off-by: Brian Norris > Cc: Luis R. Rodriguez Thanks for the patch. Applied to linux-kselftest next for 4.5-rc1. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978