From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753651AbcAGXvw (ORCPT ); Thu, 7 Jan 2016 18:51:52 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:50297 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752634AbcAGXvu (ORCPT ); Thu, 7 Jan 2016 18:51:50 -0500 Subject: Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list To: Andrew Morton References: <1452206137-12441-1-git-send-email-mike.kravetz@oracle.com> <20160107151356.0e131b25f5740f6046221419@linux-foundation.org> Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Hillf Danton , Hugh Dickins , Naoya Horiguchi , Davidlohr Bueso , Dave Hansen , stable@vger.kernel.org From: Mike Kravetz Message-ID: <568EF9F9.8050404@oracle.com> Date: Thu, 7 Jan 2016 15:51:21 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160107151356.0e131b25f5740f6046221419@linux-foundation.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/07/2016 03:13 PM, Andrew Morton wrote: > On Thu, 7 Jan 2016 14:35:37 -0800 Mike Kravetz wrote: > >> Hillf Danton noticed bugs in the hugetlb_vmtruncate_list routine. >> The argument end is of type pgoff_t. It was being converted to a >> vaddr offset and passed to unmap_hugepage_range. However, end >> was also being used as an argument to the vma_interval_tree_foreach >> controlling loop. In addition, the conversion of end to vaddr offset >> was incorrect. > > Could we please have a description of the user-visible effects of the > bug? It's always needed for -stable things. And for all bugfixes, really. > > (stable@vger.kernel.org[4.3] isn't an email address btw - my client barfed) Will do. As I stare at the code to come up with user visible effects, I am not convinced the fix is correct. An update will come after more study. -- Mike Kravetz