From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932066AbcAHGAr (ORCPT ); Fri, 8 Jan 2016 01:00:47 -0500 Received: from tama50.ecl.ntt.co.jp ([129.60.39.147]:56592 "EHLO tama50.ecl.ntt.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbcAHGAp (ORCPT ); Fri, 8 Jan 2016 01:00:45 -0500 Subject: Re: [PATCH 3/4] KVM: renumber architecture-dependent requests References: <1452176228-8484-1-git-send-email-pbonzini@redhat.com> <1452176228-8484-4-git-send-email-pbonzini@redhat.com> From: Takuya Yoshikawa Message-ID: <568F50BE.209@lab.ntt.co.jp> Date: Fri, 8 Jan 2016 15:01:34 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1452176228-8484-4-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit To: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Christian Borntraeger , Paul Mackerras X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/01/07 23:17, Paolo Bonzini wrote: > Leave room for 4 more arch-independent requests. In the current requests handling code, this ordering means that architecture specific requests get handled only after generic ones. If someone wants to make a generic request that needs to be handled before entering the guest from any architecture specific request handler, this can be a problem. If you can guarantee that this kind of dependencies will not be introduced in the future, this change looks good to me. Actually, I want to make the current dependencies, even between architecture specific requests, more explicitly written in the code. Takuya