From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752099AbcAHHCy (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 Jan 2016 02:02:54 -0500
Received: from mailout3.w1.samsung.com ([210.118.77.13]:27922 "EHLO
	mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751213AbcAHHCw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 Jan 2016 02:02:52 -0500
X-AuditID: cbfec7f5-f79b16d000005389-18-568f5f18fb91
Subject: Re: [PATCH 1/2] power: act8945a: add charger driver for ACT8945A
To: "Yang, Wenyou" <Wenyou.Yang@atmel.com>
References: <1452219225-10510-1-git-send-email-wenyou.yang@atmel.com>
 <1452219225-10510-2-git-send-email-wenyou.yang@atmel.com>
 <CAJKOXPdzYJP_9DZUTz3EXPu4Z-DwkzYOJKEiR8varKJP3RRymw@mail.gmail.com>
 <B256D81BAE5131468A838E5D7A243641D63E5A3E@penmbx01>
Cc: Sebastian Reichel <sre@kernel.org>,
        Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        "Ferre, Nicolas" <Nicolas.FERRE@atmel.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <568F5F15.8050602@samsung.com>
Date: Fri, 08 Jan 2016 16:02:45 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-version: 1.0
In-reply-to: <B256D81BAE5131468A838E5D7A243641D63E5A3E@penmbx01>
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMIsWRmVeSWpSXmKPExsVy+t/xa7oS8f1hBrNX6FtMevKe2WLiysnM
	Fv1vFrJanHu1ktHi9QtDi02Pr7FaXN41h83ic+8RRoul1y8yWXy73MxuMWH6WhaL1r1H2C1O
	7y6xuP1rA4sDn8eaeWsYPRb82sricbmvl8lj56y77B4rl39h89i8Qstj06pOIGNJvUffllWM
	Hp83yQVwRXHZpKTmZJalFunbJXBlHPu3irngO1vFpvXb2RsYN7J2MXJySAiYSPzv+sUOYYtJ
	XLi3nq2LkYtDSGApo0TLm1esEM5TRonuaZ/AOoQFPCVeNGxnBrFFBLQkzk9oYIEo+scocexk
	ByOIwyywnUXi18+JYB1sAsYSm5cvYQOxeYE6Fk+4wQJiswioSuw73wxUw8EhKhAhsWhHJkSJ
	oMSPyffASjgFHCQ+7jvKDlLCLKAuMWVKLkiYWUBeYvOat8wTGAVmIemYhVA1C0nVAkbmVYyi
	qaXJBcVJ6blGesWJucWleel6yfm5mxghUfV1B+PSY1aHGAU4GJV4eDl29IUJsSaWFVfmHmKU
	4GBWEuGVkO8PE+JNSaysSi3Kjy8qzUktPsQozcGiJM47c9f7ECGB9MSS1OzU1ILUIpgsEwen
	VAOj2u+5DudDUrfsf36wWJLZbX5fpV5m2+wDy1LPPnTZ0FER5trobi/wtdzwkeKD86ZBibde
	slqe1IwTfLTryomuvtjoxwbT1txenKR1ZbP2vsMaNluONWj+3nH2T7VaJv/Hrsj/HFO22zDY
	yDy7dqyP31Pov+u6SPXF63unO8/9N+FlNNt6z++8SizFGYmGWsxFxYkAIJEXeKYCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 08.01.2016 15:43, Yang, Wenyou wrote:

[...]

>>> +static struct platform_driver act8945a_charger_driver = {
>>> +       .driver = {
>>> +               .name = "act8945a-charger",
>>> +       },
>>> +       .probe  = act8945a_charger_probe,
>>> +       .remove = act8945a_charger_remove, };
>>> +
>>> +static int __init act8945a_charger_init(void) {
>>> +       return platform_driver_register(&act8945a_charger_driver);
>>> +}
>>> +subsys_initcall(act8945a_charger_init);
>>
>> Why subsys_initcall? This should be regular module_platform_driver.
> 
> I want it to register early enough as MFD.  Maybe I am wrong.

No, you shouldn't manually order the probing by initcalls. This should
be registered as usual and, if needed, support deferred probing. In this
case I even can't find any reason to register it earlier than usual.


Best regards,
Krzysztof