From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932095AbcAHJfu (ORCPT ); Fri, 8 Jan 2016 04:35:50 -0500 Received: from mail-bl2on0088.outbound.protection.outlook.com ([65.55.169.88]:38992 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752077AbcAHJfn (ORCPT ); Fri, 8 Jan 2016 04:35:43 -0500 Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a69-f797e6d000000b05-da-568f82ea4e8d Subject: Re: [PATCH 4/4] ib_srpt: Convert acl lookup to modern get_initiator_node_acl usage To: "Nicholas A. Bellinger" References: <1452237348-2277-1-git-send-email-nab@daterainc.com> <1452237348-2277-5-git-send-email-nab@daterainc.com> <568F78DB.9090404@sandisk.com> <1452244633.27508.21.camel@haakon3.risingtidesystems.com> CC: "Nicholas A. Bellinger" , target-devel , linux-scsi , lkml , Sagi Grimberg , Christoph Hellwig , Hannes Reinecke , Andy Grover , Vasu Dev , Vu Pham From: Bart Van Assche Message-ID: <568F82E7.4020006@sandisk.com> Date: Fri, 8 Jan 2016 10:35:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1452244633.27508.21.camel@haakon3.risingtidesystems.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrLIsWRmVeSWpSXmKPExsWyRoxnke6rpv4wg7abShb7Zz1jstizaBKT xcrVR5ksLu+aw2bRfX0Hm8WrcyuYLNpWn2G0uNH2gM2idelbJou9j/wspp96yOjA7bH0wypm j/vbjzB5zDsZ6LH7ZgObx7Pph5k83u+7yuax+XS1x+dNcgEcUVw2Kak5mWWpRfp2CVwZU06K F3QIV6xftZa5gXE7fxcjJ4eEgInEt9ObWSBsMYkL99azdTFycQgJnGCUmP7nNzuEs51Rov3d eRaYjsv7PjFDJDYzSmx++w8sISwQK9HwsYW1i5GDQ0TAUOLD0UqImiuMEkcf3GACqWEW+MUk 8WNJFYjNJmAk8e39TLBeXgEtiaOfbjGC9LIIqEjM6QkACYsKREj82LCEEaJEUOLkzCdg5ZwC bhIdt+4wQ4y0kJg5/zwjhC0vsf3tHLDbJAQa2ST6r54GaxASUJc4uWQ+0wRGkVlIZs1C0j8L Sf8CRuZVjGK5mTnFuempBYZGesWJeSmZxdl6yfm5mxjBkciVuYNxxSTzQ4wCHIxKPLwcO/rC hFgTy4orcw8xSnAwK4nwLiruDxPiTUmsrEotyo8vKs1JLT7EKM3BoiTOa92iFiYkkJ5Ykpqd mlqQWgSTZeLglGpgjObMnhUkcV/sedJKThezf7ar3xrzXW1KqNZisjLwmLb5ZoZY5COjhyui 7PilPTPjjJ+42afwf+xtubb3M+OtPwtm7Zsc+5/71m+ZxMitMicXtV2rORkZeO6V5PQd6559 jbx82dLt0m3nIysZJzYd/q0l9PLQiUqrN03z7c1bp+71rPrbY7TRXImlOCPRUIu5qDgRACnR raPAAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMLMWRmVeSWpSXmKPExsXCtZEjRfdVU3+YwYrJ/Bb7Zz1jstizaBKT xcrVR5ksLu+aw2bRfX0Hm8WrcyuYLNpWn2G0uNH2gM2idelbJou9j/wspp96yOjA7bH0wypm j/vbjzB5zDsZ6LH7ZgObx7Pph5k83u+7yuax+XS1x+dNcgEcUVw2Kak5mWWpRfp2CVwZU06K F3QIV6xftZa5gXE7fxcjJ4eEgInE5X2fmCFsMYkL99azdTFycQgJbGSU+Hr7KwtIQlggVqLh YwtrFyMHh4iAocSHo5UQNVcYJY4+uMEE4jAL/GGSeHL5OytIA5uAkcS39zPBmnkFtCSOfrrF CNLMIqAiMacnACQsKhAh8WPDEkaIEkGJkzOfgJVzCrhJdNy6A3YQs4CZxLzND6FseYntb+cw T2Dkn4WkZRaSsllIyhYwMq9iFMvNzCnOTc8sMDTUK07MS8ksztZLzs/dxAiOBs7IHYxPJ5of YmTi4JRqYIwx2iNuEJn0beWEwzOtaltPFbHxxR7laF2TZfPjlbf9bN5qUeenTfuUrtWlTz7v uZa7qMG0+nLNNUXHik/VUmwarx9sZ/jgdnb/gfczrpz7VL6sRqNG6fqanUf8focU3VBp/Ob0 p0Qo3b5U8uZ/yZvhFdmHm/YfaNglFM3/9QBLiZ3L0Qusi5VYijMSDbWYi4oTAV/M+sU2AgAA X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1AFFO11FD009;1:gJvxoHFgfb5RJnvG1LtK68dK5FEd6D9M2rlqLjOtf1kkGZ46herR9WxaidOOgVTGJnjREK4AvAyMoh5jfVGajuyqlVJ3spAI/3g9JnUVh+IayNCjWzO3+Vo+0eOy8hOMIuMPWcKDdTPJ7SErUYpdO3STUKuuXkSsF/kJfjPSBScn2Ihq3/4b75rQ4dOZsGjevbkHgUiGfeBrei+PWw8h2SlorAYZ4i196lQZHnlFVS5IxbKpt8Nyyi5tAK4sDyWb6KUx967XRbD2FjYXaRtgh6LFoQQjvbdMjf49VfZD+WrScy6ZX3WhVby3W8OU2PMteHjItCuYo3oGzQV4kAQVTy2lhwg3TTmxPZ0EaGpvZ0dQXR/OZjWJdcfZ6NSg9IBFD/jIDZl9VsaHvsWJ1nfNxg== X-Forefront-Antispam-Report: CIP:63.163.107.173;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(479174004)(377424004)(189002)(199003)(377454003)(24454002)(81156007)(4001350100001)(64126003)(33656002)(47776003)(83506001)(50986999)(87266999)(80316001)(86362001)(2950100001)(586003)(65806001)(65816999)(69596002)(65956001)(230700001)(77096005)(1220700001)(5008740100001)(189998001)(1096002)(92566002)(110136002)(97736004)(50466002)(93886004)(106466001)(59896002)(11100500001)(87936001)(23676002)(5001960100002)(4326007)(54356999)(36756003)(2906002)(76176999);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR02MB297;H:milsmgep12.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB297;2:3E7DpOMKIHtz+3EwMP8F6+WxNazgXi8KjIaqzXOfvPWZpczxHoyYzo7UHJXe3dQIzrxfrY8l7K5Ho0QckDBeRnfcKaeJt0oVdDSbpU6/0lWTDdI26hIqfiFxJvSVIKpCcEfs3Q761Nipc3dTtF7qDQ==;3:pdyv/ZnDqnLdu4D/cg3SvUcsdqXvDxM/DMv0fTpKcIvOTD28yoXaM6/xOtO7+PXKZr01giT66qcrKnjIJN8blt4XeGJhUpGnjxay8q+OGg37PKEeW1VBntlDz6Ddy9UGB8lwa7p6vXxfWRCi/k2E7tns618J6T7IIpxRoDHEEf95qTxO8O7Kv0PRCsxpaZPMVXYwPrPf3ov2vmLHxMnAxa6Jkv4Mlg6Avw+u0v6dFY1+zl1uFXrylXQS1ojcbtx6dhU7J4TiiqQLrg/OhX5t5w==;25:AwCCKQKVUpy/neWPFDvUbVCJAagfYCKlG6xRiP6zJf3QkpyEJXjC7Y9s1Ug1zwhMoe+wia20aD7je0VGqueJI7DhG4nwhYCMoJjWF+kdvy80Nbzc4DqZe1qRGm67Z3akspVoSJp7lNe8BAhhuXw1Pf16X7a7Ct59Sf0IQgrzwcRH+aBCqDCD3f//CCH7HQGEhfDQKwW2Ah4hkb0G6o8sB/tnfJh06y57cU04RpPNmRAukleLj4XW+9CY+JaGATbC X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BY2PR02MB297; X-MS-Office365-Filtering-Correlation-Id: 49edebde-733f-4470-0346-08d3180f1246 X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB297;20:iEyewlofTHDyvmXqsseW4N2OVHSAZs0Payanj+WaFj3Di2b/Rit6ZsJVo2f9MoliCMToO9CclNVEVuaAUp2DETe550WKZXkSdpcfj048xYL6SlOaeevZy3MtZlmmgBKpniCKZbnGWpwJk4AviB5d1k2fxRxuroun1iprtIJPmFbekaqJYiewHYmemf2pERub1GGTWzNIQmjHWA+F3+lj6GnQtOnT0CR80CGcBdR7bezUVQ/s1cy98+meSX7DVYK36goshSmVDjIlfHFvTkfrJoKIKiO1LuzrxJ/RS6om2VV1m2vi5OsQ+kjU/rPVLnTuuU/Pw3XTJ7/JsnI9Fd+bBN8c5NcsY21t6dZUotLGKiBBeoRLSPdVtovQgvwPYCj1j9uo+WwXm2WRqhaWubaH1KIivQVakABAWf1KmmMKndY9/WWMoM4Gmh/seMZPoqeo873uAQoMtc8N75Vjn2kQ7zsX/Qr6G1q5Vayx+yyqcVB/WygelWIuUyL8IK8h/hZg;4:tig130XUkL/wHaUF5fETyGHf4UOTcDyuYSS02j8S3zszOmxDnEjm3Ik+Gn1/r7B4l//qEuSBx7qBxhFNdzK/WB8Dqvo8HtjchCRJWDd2YcRVwraOsqtnKwgKSWl9lC2a9NYdVDu/Ve1A7620Xovi4+8NPEFxzVyUnHV7kbtRt1CJ2L7LqDKNUI77L8UzCDRgE0QluWyrjq7rrZxgwHABXoCbhDNKTH6TfYUTO+dwRe5w5eBBTy0z+6/dBZ/S2Q0ktXZVUcOAqk10o6yfi8BegFvje/cRpQCqOQNZOkp8aquNGKI+N8QgZhlY0Q/fwxsd5kZtt9WexyWUFHnW5p4DNSBo9p7B21udL2A592WaXHu/MWu1n2GX75GYkC1ScvAmhjhO4m5q/zjPr1LjBV6daClrJhJyAPZBZTYtRNnec9g= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(13017025)(13015025)(5005006)(8121501046)(3002001)(10201501046);SRVR:BY2PR02MB297;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB297; X-Forefront-PRVS: 0815F8251E X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCWTJQUjAyTUIyOTc7MjM6RGJXdS9jelBhc1JybERIdmpFOGV6ckNrZDRj?= =?utf-8?B?OXVUbk9jSmpqMHY0TDg3YXZMU3BrSE1ad2IyeEpIZFdieUZDR1FqS3hFZ1g5?= =?utf-8?B?QnMzSzVNbCtncVIvMjF2UWFmK0kyZkt6S3ZmZ29Ta2IvTVJZVXpJTElHNTl6?= =?utf-8?B?L28rSTZHWnUyMGZZcDdha2V1Qk1IbWFucm9RSFV3aFhjNzN2dlpvNUpxTjhQ?= =?utf-8?B?emxRSFBtaWozQWU5MEpxU21md0JuK1RFdGJueFMyL2Z3WGxTc1Vjd0VteCt1?= =?utf-8?B?YlkrRmdHaVNVK3ZaajNPT0VVT1ZsN2FCUUJFNWZFSU41OGkyZEVtQ2ZDdU9K?= =?utf-8?B?V1BNd3VjeFZFNW1IT3lNVzRZYkFJY3NVOFpvUmxpY0NNNDlyNHhzcE9EY1hF?= =?utf-8?B?OFlNRy9zcDZzSks1SjlsMk1pWGxVNFRLd2cwR0thK0R6dThCUUFHSlIxTzVv?= =?utf-8?B?UVYzTmVjQ2g0OUhDZHdtSllqOFpWblZBQzZ0Q2JqdDg5amtQVVRHMW5heWh0?= =?utf-8?B?RDBkMEU3UURqTnptaFVuOXFvRWdwRDgvQlJuR2ZVbGhVOGhsOVdHQnhvV0Jn?= =?utf-8?B?WFh3SjlubmNGTWNlK1RjaVlLaFdRVU1zbkM0eitidUkyMFlGYjdmNkpLTHRU?= =?utf-8?B?Q28wVjRVcHAwVUIwbWVCNlpWYzJIMnA0Wm15eGVzZFNySXhhT2FMN21GZ1dj?= =?utf-8?B?K2IzbkdYM1ladjJCMjljODd2MHpXWGJ2ZnJkLzUzLzlvN3hlRGwvanpMZE9K?= =?utf-8?B?Tmh2YUE0bk5TUlVONXM3TUk2RmVpaXNhUUx2bVl4ZkxTZkFHK0xvZ3lrZkta?= =?utf-8?B?UmIwM0hlb3hNL3QvZzV3TjBCcFd0K05WTlFQSURvTWFBblpiMDNTR0JrcTRn?= =?utf-8?B?NnJpUmY4dW0rT0pJRUNLQzVjR2lZSitGa2FobU9tS2pqUEZ3RTRreHcwT2hK?= =?utf-8?B?OWNZUFc2bjZHMzUxQVR0QlNXc1ExNlQyd2wwVFpKTGl4LzBscGJSRzlhbjFV?= =?utf-8?B?elR0OU1sL3c1UE1KMUlQKzR3Nnd3RllOZFNDMEN5SGYxSHJDTDlac2VYTEda?= =?utf-8?B?UVgxZ3hvZEVSWnhpejZURHNjSXdySlJEeEttKy9EcDV1WnBRTFpaYStXbllE?= =?utf-8?B?QVRvbU4wS3B6djR0ZUt6djNlSlJmazRCRnZRcnl0dkxod3VpMzdnR0c2by94?= =?utf-8?B?NENFZW9Sa0R0cnJKVjFkMGdNQVdDb25BSDk3TG9wQlJNVGllZFdrK1FSSURK?= =?utf-8?B?SEt1ZDNsRHdvcmFJL3BodzdPaFg1NkxZNWFoZGpzOHFLTExmYWR2K1BBL0hn?= =?utf-8?B?LzBKbGN0VmR3bGNrSi9wR3RDZjNuNG82WDFTWU82L05ZZndkeGs2OTZxWTJV?= =?utf-8?B?b3NRZnBacFVKUG1oRThBOC9jNlZMZHRwNlA4MGMveGI2cWk3MnVWd29KN3dX?= =?utf-8?B?QWlmWUZYS3lVOUFqUjhnVG84UU1NaTNzdG9YYWNuTWw2YVRBTml2MDd3ZVZO?= =?utf-8?B?WHZ0Nk5EZUV6bEkwUEZmTUhpdzZrb203UGNDTjNGeGgrRmpjeUl5YURBdjhW?= =?utf-8?B?eGpqSVpQQ2luQzZIaTV1V004TENrOENzTTFyaFBmTzcycUkxREs2VHQ5U3dl?= =?utf-8?Q?0n8HJmHLO2iiVlm4XUp?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB297;5:8VHKwl7Xjz8tr1AN1FijTgLkFnKd8OV8VqDom9dsbxFPMArAdTz8FsobKuEXhOUsJaJMudkaGFa1+lV5L3oGwYlxTfbf1K++Id1YSECTgzKlCEI4U5s9PGoy7sEkoQUqOxDbz0AIPDVVQi4bkvF7zQ==;24:GZmUB38lCXNlCkstW17ZrT8SjQ+sfmASveAuPrbxQavLhVO55gNd4Vt2fmZzVG0wYW3PNWvwvJP2wx/cwbwxSFiKLE6bCR8ecv/5rxNYeHM=;20:tbe+OkVA1yz9YY9ooLdNpFhlw1/7PMHSuSqEK2yq4BeJvp6wHZbGUtJ5rrQHwcQJcUsif0yerk3BliHJHdxS/wvMTyaUT5YeCmThejntbeMCzK4MCKUu90cOOPS2qsA4u7cMc3ZFqEhX3tyUhlvQGclJQb7HyLAkexvcZX7UbP9Pbo6mLi2/G7qlmrxVu6kKGtqkQdn4PJascGnrrJM7r/yAZLAGluo5VolobyidwZuNpVWsTjM/BFkcdoXg6vV8 SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2016 09:35:39.0010 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173];Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB297 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/08/2016 10:17 AM, Nicholas A. Bellinger wrote: > On Fri, 2016-01-08 at 09:52 +0100, Bart Van Assche wrote: >> On 01/08/2016 08:15 AM, Nicholas A. Bellinger wrote: >>> @@ -2574,24 +2558,18 @@ static int srpt_cm_req_recv(struct ib_cm_id *cm_id, >>> >>> pr_debug("registering session %s\n", ch->sess_name); >>> >>> - nacl = srpt_lookup_acl(sport, ch->i_port_id); >>> - if (!nacl) { >>> + se_acl = core_tpg_get_initiator_node_acl(&sport->port_tpg_1, ch->sess_name); >>> + if (!se_acl) { >>> pr_info("Rejected login because no ACL has been" >>> " configured yet for initiator %s.\n", ch->sess_name); >>> rej->reason = cpu_to_be32( >>> - SRP_LOGIN_REJ_CHANNEL_LIMIT_REACHED); >>> + SRP_LOGIN_REJ_CHANNEL_LIMIT_REACHED); >>> + transport_free_session(ch->sess); >>> goto destroy_ib; >>> } >>> + ch->sess->se_node_acl = se_acl; >> >> This is a backwards-incompatible change. Today the ib_srpt target driver >> accepts initiator port names with and without leading "0x". With this >> change the "0x" prefix becomes mandatory. > > The internally ib_srpt formatted ch->sess_name already needs to match > se_node_acl->initiatorname for se_node_acl->acl_group configfs group > shutdown reference.. > > How does this patch become a backworks-incompatible change for that..? Hello Nic, Personally I'm not that worried about this change but I wanted to report it anyway. The current algorithm is as follows: - When a directory is created in configfs for an initiator, the initiator name is parsed and stored in binary form in struct srpt_node_acl. The parsing function accepts both initiator names that start with a "0x" prefix and initiator names that do not have that prefix. - During login the initiator port ID provided by the initiator in the SRP login request is compared with the binary initiator port ID in struct srpt_node_acl. The patch at the start of this e-mail thread changes this behavior because core_tpg_get_initiator_node_acl() looks up the initiator port ID in a list that contains the ASCII representations of the initiator port ID. This means that the initiator port name will only be found by core_tpg_get_initiator_node_acl() if the name format used in the mkdir command matches the initiator name format used by the core_tpg_get_initiator_node_acl() caller, this means with "0x" prefix. Bart. Bart.