From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Caesar Wang <wxt@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-rockchip@lists.infradead.org, leecam@google.com,
leozwang@google.com, keescook@google.com,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexandre Courbot <acourbot@nvidia.com>,
NeilBrown <neil@brown.name>
Subject: Re: [PATCH v2 06/12] mmc: pwrseq: add support for power-on sequencing through DT
Date: Fri, 8 Jan 2016 09:22:31 -0300 [thread overview]
Message-ID: <568FAA07.1010509@osg.samsung.com> (raw)
In-Reply-To: <1452155155-16232-7-git-send-email-wxt@rock-chips.com>
Hello Caesar,
On 01/07/2016 05:25 AM, Caesar Wang wrote:
> This patch enables support for power-on sequencing of SDIO
> peripherals through DT.
>
I think the subject line and this first paragraph are misleading since
the simple power sequence provider already supports power-on sequencing.
This patch does not add or enable support but extends the current support
to also enable a regulator as a part of the SDIO chip power on sequencing.
> In general, it's quite common that wifi modules and other similar
> peripherals have several signals in addition to the SDIO interface that
> needs wiggling before the module will power on.
>
> For example:
> we need enable wifi module power to via the WL_REG_ON
> pin, we need enable it as the regulator if this pin is connected to
> the gpio of cpu.
>
This part confuses me, so does your chip have an actual regulator that
needs to be enabled or is just a fake regulator whose gpio property is
used not to enable the regulator but to toggle the WL_REG_ON pin of
the WiFi chip?
> Maybe, someone will say that can pull up/down from dts.
> Unfortunately some SoCs can't support pinctrl pull up/down in
> internal.
>
Can you please elaborate on this? AFAIU this limitation is the reason
why you went with the regulator approach so I think it deserve a more
deep explanation.
> Anyway, we can add this patch to supprt the power-on sequencing for
s/supprt/support
> sdio.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-01-08 12:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 8:25 [PATCH v2 00/12] Add the family patches to support for kylin board Caesar Wang
2016-01-07 8:25 ` [PATCH v2 01/12] ARM: dts: rockchip: set the pinctrl default setting for rk3036 i2s Caesar Wang
2016-01-09 2:17 ` Heiko Stuebner
2016-01-07 8:25 ` [PATCH v2 02/12] ARM: dts: rockchip: add the sound codec for kylin board Caesar Wang
2016-01-09 2:39 ` Heiko Stuebner
2016-01-07 8:25 ` [PATCH v2 03/12] ARM: dts: rockchip: override the clocks in i2s " Caesar Wang
2016-01-09 2:31 ` Heiko Stuebner
2016-01-11 13:38 ` Caesar Wang
2016-01-07 8:25 ` [PATCH v2 04/12] clk: rockchip: rk3036: enable the CLK_IGNORE_UNUSED flag for sclk_i2s_out Caesar Wang
2016-01-07 10:05 ` Heiko Stuebner
2016-01-08 9:26 ` Caesar Wang
2016-01-08 9:46 ` Heiko Stuebner
2016-01-13 8:10 ` Caesar Wang
2016-01-07 8:25 ` [PATCH v2 05/12] mmc: pwrseq: Document optional exteral vcc for the simple power sequence Caesar Wang
2016-01-08 12:13 ` Javier Martinez Canillas
2016-01-07 8:25 ` [PATCH v2 06/12] mmc: pwrseq: add support for power-on sequencing through DT Caesar Wang
2016-01-08 12:22 ` Javier Martinez Canillas [this message]
2016-01-09 2:42 ` Heiko Stuebner
2016-01-11 16:02 ` Javier Martinez Canillas
2016-01-15 9:15 ` Caesar Wang
2016-01-07 8:25 ` [PATCH v2 07/12] ARM: dts: rockchip: enable the high speed on sdio for kylin board Caesar Wang
2016-01-07 8:25 ` [PATCH v2 08/12] ARM: dts: rockchip: add the wifi/bt regulator " Caesar Wang
2016-01-07 8:25 ` [PATCH v2 09/12] ARM: dts: rockchip: enable the uart0 " Caesar Wang
2016-01-07 8:25 ` [PATCH v2 10/12] ARM: dts: rockchip: add the sdmmc " Caesar Wang
2016-01-07 8:25 ` [PATCH v2 11/12] ARM: dts: rockchip: add the lcdc and hdmi node for rk3036 Caesar Wang
2016-01-07 8:25 ` [PATCH v2 12/12] ARM: dts: Add pl330-broken-no-flushp quirk for rk3036 SoCs Caesar Wang
2016-01-07 10:44 ` [PATCH v2 00/12] Add the family patches to support for kylin board Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568FAA07.1010509@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=acourbot@nvidia.com \
--cc=heiko@sntech.de \
--cc=keescook@google.com \
--cc=leecam@google.com \
--cc=leozwang@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=neil@brown.name \
--cc=srinivas.kandagatla@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome