From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B4D5C636CC for ; Thu, 16 Feb 2023 09:21:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229534AbjBPJVJ (ORCPT ); Thu, 16 Feb 2023 04:21:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229575AbjBPJVG (ORCPT ); Thu, 16 Feb 2023 04:21:06 -0500 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B86ECC29 for ; Thu, 16 Feb 2023 01:21:05 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id n20so2043440edy.0 for ; Thu, 16 Feb 2023 01:21:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QICcZD+PgFsGFoOEwt7J2Od7jkS4WHo0ZTXSjNqBbTc=; b=mfpHDB8Oy6XWEJRnuYg0wHDj4hNxQ7QE770q5mLgqIOHo65Pspkhpct8QewFldFv4v 3R6v6Zfzrp42R17ah1Ef8ki3OAAraUtNfpzfAMRyqk/fjnIa94kOzwedskNG9JVUOGDR JUEOCbG6EDUguPOCVeHFNLN9auDkEjW5ELjrMjcqvSA4iG8NfkJELki0aMUf2j/mCOcj v8E7OQxBHS8b2KwESqZluTj9ybEaX4OLiXA/KedEhqnVrE7/PoIBs+SPh0kRuPoPctc3 P/D6jL9/CrcUMQI15rwz5ZUVjUEP3hqziE+y/IO/7QpXoBQxmf6mG8OKI6edmd4YIODF uq7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QICcZD+PgFsGFoOEwt7J2Od7jkS4WHo0ZTXSjNqBbTc=; b=bmDxNI/vgU6RWeHxEVXVumP5fP5E0W8/VDhtUARl0Q3STabWl+8B0bs5rMBYlnu6XE DV2k3EnSkECKGJEN23BJiP7KxZsni2Q6Xp/0v8QCMMoRI9d0LNyT7ycfI+WQ0p1TFj8/ DXnf0Wy2hkr/9GZgQN8OZAH1XwMVEV/OV8ZmR18p5lEirZFOqcQeVl4KXy9haqQC3zIP DmtB14GybYTkX0psAT1FR3MLyVPJauAv0sxHjacpBdEBllVpl2nf1bZaJJ/6+BSJA7vf L0u8lFlakHZ7+tEh+5HErdUX/UGFBs3hx5rFGZZ7kqpPArCM9rimnLf/AJQKsPSzGlNa jzNw== X-Gm-Message-State: AO0yUKX3amCwOPeZBlDcnzQ5dz1sxlAKW8mjgtgt54QcyTC9QQ8gMVM2 FFNH6QR3dlb4HP+EYjl+VGhKRuEeTTLjUfQM X-Google-Smtp-Source: AK7set9STcXussFDXouuPm3WzxGdJij6lEuQJwj8KfQn4K+7Yi2MLpesEfjeb9R8T/OKd77L0RkYFg== X-Received: by 2002:aa7:c981:0:b0:4ab:16a8:bc64 with SMTP id c1-20020aa7c981000000b004ab16a8bc64mr5324123edt.24.1676539263978; Thu, 16 Feb 2023 01:21:03 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id v9-20020a509549000000b004acc6cbc451sm552809eda.36.2023.02.16.01.21.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 01:21:03 -0800 (PST) Message-ID: <568d585c-0f89-0b0b-3cbe-d3025208cdea@linaro.org> Date: Thu, 16 Feb 2023 10:21:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 3/3] arm64: dts: qcom: sa8775p: add the GNSS high-speed UART for sa8775p-ride Content-Language: en-US To: Bartosz Golaszewski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski References: <20230214155715.451130-1-brgl@bgdev.pl> <20230214155715.451130-4-brgl@bgdev.pl> From: Krzysztof Kozlowski In-Reply-To: <20230214155715.451130-4-brgl@bgdev.pl> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/02/2023 16:57, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add the serial port connected to the GNSS on sa8775p-ride. > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 34 +++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 17 ++++++++++++ > 2 files changed, 51 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > index d01ca3a9ee37..9aee6e4c1ba1 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts > @@ -13,6 +13,7 @@ / { > > aliases { > serial0 = &uart10; > + serial1 = &uart17; > i2c18 = &i2c18; > spi16 = &spi16; > }; > @@ -66,6 +67,30 @@ qup_i2c18_default: qup-i2c18-state { > drive-strength = <2>; > bias-pull-up; > }; > + > + qup_uart17_cts: qup-uart17-cts-state { > + pins = "gpio91"; > + function = "qup2_se3"; > + bias-disable; > + }; > + > + qup_uart17_rts: qup0_uart17_rts-state { No underscores in node names. Does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof