From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Mike Fedyk <mfedyk@matchmail.com>
Cc: colpatch@us.ibm.com, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@digeo.com>
Subject: Re: [TRIVIAL PATCH] Ensure pfn_to_nid() is always defined for i386
Date: Mon, 05 Jan 2004 15:15:33 -0800 [thread overview]
Message-ID: <5690000.1073344532@[10.10.2.4]> (raw)
In-Reply-To: <20040105225340.GB1882@matchmail.com>
>> + * for now assume that 64Gb is max amount of RAM for whole system
>> + * 64Gb / 4096bytes/page = 16777216 pages
>> + */
>> +#define MAX_NR_PAGES 16777216
>> +#define MAX_ELEMENTS 256
>> +#define PAGES_PER_ELEMENT (MAX_NR_PAGES/MAX_ELEMENTS)
>
> Why not do the calculation in the define, and use PAGE_SIZE?
>
> If PAGE_SIZE isn't 4k will it break the rest of this code, or will the
> calculations make sence with larger PAGE_SIZE?
>
> Might as well make it easier to go in the direction of variable PAGE_SIZE
> instead of keeping the assumption.
The patch is just moving the code, not changing it ;-)
But yes, that value could probably be derived instead of hardcoded.
Separate patch though.
M.
next prev parent reply other threads:[~2004-01-05 23:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-22 19:44 Matthew Dobson
2003-12-23 0:26 ` Martin J. Bligh
2004-01-05 21:35 ` Matthew Dobson
2004-01-05 22:53 ` Mike Fedyk
2004-01-05 23:15 ` Martin J. Bligh [this message]
2004-03-29 15:45 ` Martin J. Bligh
2004-03-29 15:45 ` Matthew Dobson
2004-03-29 15:45 ` Mike Fedyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='5690000.1073344532@[10.10.2.4]' \
--to=mbligh@aracnet.com \
--cc=akpm@digeo.com \
--cc=colpatch@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfedyk@matchmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®