From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756629AbcAHT0A (ORCPT ); Fri, 8 Jan 2016 14:26:00 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:58564 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753526AbcAHTZ6 (ORCPT ); Fri, 8 Jan 2016 14:25:58 -0500 To: LKML Subject: [PATCH] logfs: fix logfs build errors and dependencies Cc: Andrew Morton , Joern Engel , Prasad Joshi , logfs@logfs.org, Stephen Rothwell From: Randy Dunlap X-Enigmail-Draft-Status: N1110 Message-ID: <56900D3E.50200@infradead.org> Date: Fri, 8 Jan 2016 11:25:50 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap Fix build errors that happen when CONFIG_LOGFS=y and CONFIG_MTD=m: fs/built-in.o: In function `logfs_mount': super.c:(.text+0x92a6f): undefined reference to `logfs_get_sb_mtd' fs/built-in.o: In function `logfs_get_sb_bdev': (.text+0x93530): undefined reference to `logfs_get_sb_mtd' This change allows CONFIG_BLOCK and CONFIG_MTD to be disabled, but if either of them is enabled, CONFIG_LOGFS is limited (restricted) by the setting of the former symbol(s). Signed-off-by: Randy Dunlap Cc: Joern Engel Cc: Prasad Joshi Cc: logfs@logfs.org --- fs/logfs/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Found in linux-next but applies to mainline also. --- linux-next-20160108.orig/fs/logfs/Kconfig +++ linux-next-20160108/fs/logfs/Kconfig @@ -1,6 +1,7 @@ config LOGFS tristate "LogFS file system" - depends on (MTD || BLOCK) + depends on BLOCK || BLOCK=n + depends on MTD || MTD=n select ZLIB_INFLATE select ZLIB_DEFLATE select CRC32