From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752837AbdGXGGk (ORCPT ); Mon, 24 Jul 2017 02:06:40 -0400 Received: from hermes.aosc.io ([199.195.250.187]:58966 "EHLO hermes.aosc.io" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751799AbdGXGGW (ORCPT ); Mon, 24 Jul 2017 02:06:22 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 24 Jul 2017 14:06:20 +0800 From: icenowy@aosc.io To: Chen-Yu Tsai Cc: Lee Jones , Rob Herring , Maxime Ripard , Jonathan Cameron , Quentin Schulz , devicetree , linux-arm-kernel , linux-kernel , linux-iio@vger.kernel.org, linux-sunxi Subject: Re: [linux-sunxi] [PATCH v3 2/5] iio: adc: sun4i-gpadc-iio: rename A23/A33-specified registers to contain A23 In-Reply-To: References: <20170723141354.42646-1-icenowy@aosc.io> <20170723141354.42646-3-icenowy@aosc.io> Message-ID: <56900ea0ab9a28aea673d68097049354@aosc.io> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2017-07-24 14:02，Chen-Yu Tsai 写道： > On Sun, Jul 23, 2017 at 10:13 PM, Icenowy Zheng > wrote: >> As the H3 SoC, which is also in sun8i line, has totally different >> register map for the thermal sensor (a cut down version of GPADC), we >> should rename A23/A33-specified registers to contain A23, in order to >> prevent obfuscation with H3 registers. Currently these registers are >> only prefixed "SUN8I", not "SUN8I_A23". >> >> Add "_A23" after "SUN8I" on the register names. > > Nit: the compatible string as well as the initial driver targets the > A33. > Naming the registers as such would be more consistent. But the registers are the same between A23 and A33. In fact the only difference between A23 and A33 is the formula's factors. > > Otherwise, > > Reviewed-by: Chen-Yu Tsai