From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755562AbcAHULw (ORCPT ); Fri, 8 Jan 2016 15:11:52 -0500 Received: from rcdn-iport-3.cisco.com ([173.37.86.74]:8379 "EHLO rcdn-iport-3.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751213AbcAHULu (ORCPT ); Fri, 8 Jan 2016 15:11:50 -0500 X-IronPort-AV: E=Sophos;i="5.20,540,1444694400"; d="scan'208";a="65261754" Subject: Re: [PATCH 1/2] drivers: pata_octeon_cf : Switch IO mode depending on model number To: Tejun Heo References: <1452230332-14926-1-git-send-email-danielwa@cisco.com> <20160108153049.GN1898@mtj.duckdns.org> Cc: Bartlomiej Zolnierkiewicz , Anil Veliyankara Madam , xe-kernel@external.cisco.com, Shikha Jain , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, "Chris Hall (hall)" From: Daniel Walker Message-ID: <56901803.209@cisco.com> Date: Fri, 8 Jan 2016 12:11:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160108153049.GN1898@mtj.duckdns.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Auto-Response-Suppress: DR, OOF, AutoReply Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/08/2016 07:30 AM, Tejun Heo wrote: > Hello, Daniel. > > On Thu, Jan 07, 2016 at 09:18:51PM -0800, Daniel Walker wrote: >> From: Anil Veliyankara Madam >> >> Since viking flash has a problem in the MWDMA mode which causes data >> corruption, this patch allows the driver to detect the model number >> and switch the IO mode to PIO6 if it's a viking flash. > Hmmm... is this specific to pata_octeon_cf or should it apply to the > device regardless of the controller in use? > > It's not specific to pata_octeon_cf , it should be applied to the device regardless of controller. Is there a better place to put this to cover all ? Daniel