From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753692AbcAIJwO (ORCPT ); Sat, 9 Jan 2016 04:52:14 -0500 Received: from a.ns.miles-group.at ([95.130.255.143]:11950 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753457AbcAIJwJ (ORCPT ); Sat, 9 Jan 2016 04:52:09 -0500 Subject: Re: [PATCH] um: Fix get_signal() usage To: Al Viro References: <1447836703-32594-1-git-send-email-richard@nod.at> <20160109035125.GA365@ZenIV.linux.org.uk> Cc: user-mode-linux-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, stable@vger.kernel.org From: Richard Weinberger Message-ID: <5690D845.5090308@nod.at> Date: Sat, 9 Jan 2016 10:52:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160109035125.GA365@ZenIV.linux.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 09.01.2016 um 04:51 schrieb Al Viro: > On Wed, Nov 18, 2015 at 09:51:43AM +0100, Richard Weinberger wrote: >> If get_signal() returns us a signal to post >> we must not call it again, otherwise the already >> posted signal will be overridden. >> Before commit a610d6e672d this was the case as we stopped >> the while after a successful handle_signal(). > > Old behaviour had been wrong. If you have several pending signals, > more than one sigframe should be built, as if the second, etc. had > been delivered right on the entry into the handler. > > Stopping after the first one is obviously wrong - consider the case > when attempt to deliver it has raised SIGSEGV. You are right. Thanks for pointing this out. Will revert. Thanks, //richard