From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Rob Herring <robh@kernel.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Peter Rosin <peda@axentia.se>,
Aswath Govindraju <a-govindraju@ti.com>
Cc: <linux-can@vger.kernel.org>, <linux-phy@lists.infradead.org>,
<linux-renesas-soc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] phy: can-transceiver: Re-instate "mux-states" property presence check
Date: Wed, 19 Mar 2025 18:35:47 +0300 [thread overview]
Message-ID: <5691f9a6-07f0-4295-a25d-cb5bc572e824@omp.ru> (raw)
In-Reply-To: <6bcfde63b3a6b25640a56be2e24a357e41f8400f.1742390569.git.geert+renesas@glider.be>
On 3/19/25 4:27 PM, Geert Uytterhoeven wrote:
> On the Renesas Gray Hawk Single development board:
>
> can-transceiver-phy can-phy0: /can-phy0: failed to get mux-state (0)
>
> "mux-states" is an optional property for CAN transceivers. However,
> mux_get() always prints an error message in case of an error, including
> when the property is not present, confusing the user.
>
> Fix this by re-instating the property presence check.
>
> This is bascially a revert of commit d02dfd4ceb2e9f34 ("phy:
Basically. :-)
> can-transceiver: Drop unnecessary "mux-states" property presence
> check"), with two changes:
> 1. Use the proper API for checking whether a property is present,
> 2. Do not print an error message, as the mux core already takes care
> of that.
>
> Fixes: d02dfd4ceb2e9f34 ("phy: can-transceiver: Drop unnecessary "mux-states" property presence check")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Alternatively, the multiplexer subsystem needs to gain support for
> getting an optional mux...
[...]
MBR, Sergey
next prev parent reply other threads:[~2025-03-19 15:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 13:25 Geert Uytterhoeven
2025-03-19 13:27 ` Geert Uytterhoeven
2025-03-19 14:06 ` Vincent Mailhol
2025-03-19 15:48 ` Vincent Mailhol
2025-03-20 10:25 ` Geert Uytterhoeven
2025-03-20 11:29 ` Vincent Mailhol
2025-03-19 15:35 ` Sergey Shtylyov [this message]
2025-03-20 15:00 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5691f9a6-07f0-4295-a25d-cb5bc572e824@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=a-govindraju@ti.com \
--cc=geert+renesas@glider.be \
--cc=kishon@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®