From: wanghaibin <wanghaibin.wang@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <jiangshanlai@gmail.com>,
<peter.huangpeng@huawei.com>
Subject: Re: [RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location.
Date: Mon, 11 Jan 2016 13:21:37 +0800 [thread overview]
Message-ID: <56933BE1.1060602@huawei.com> (raw)
In-Reply-To: <20160107154850.GA1898@mtj.duckdns.org>
On 2016/1/7 23:48, Tejun Heo wrote:
> On Thu, Jan 07, 2016 at 08:38:56PM +0800, wanghaibin wrote:
>> the wq_update_unbound_numa_attrs_buf will be useful, only when the
>> wq_numa_enabled is true.
>> if there is something wrong to cause the wq_numa_enable false, it
>> can just return without the wq_update_unbound_numa_attrs_buf
>> allocation.
>>
>> This doesn't introduce any functional changes.
>
> I don't see what the point is with this change.
>
What I Meant To Say, if (WARN_ON(node == NUMA_NO_NODE)) is true, this cause
wq_numa_enabled to be set the false. That is, the wq_update_unbound_numa_attrs_buf
will be useless.
It can free the the wq_update_unbound_numa_attrs_buf while the WARN_ON condition is
true;
Or, better way is that only when the wq_numa_enabled is true, we will allocate the
wq_update_unbound_numa_attrs_buf;
However, just like your said, the WARN_ON condition should never happen,
Maybe this change is not useless too :) .
> Thanks.
>
next prev parent reply other threads:[~2016-01-11 5:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 12:38 [RFC PATCH 0/4] fixs/suggestions for workqueue subsystem wanghaibin
2016-01-07 12:38 ` [RFC PATCH 1/4] workqueue: move the wq_update_unbound_numa_attrs_buf allocation location wanghaibin
2016-01-07 15:48 ` Tejun Heo
2016-01-11 5:21 ` wanghaibin [this message]
2016-01-07 12:38 ` [RFC PATCH 2/4] workqueue: free the allocated memory resource when wq_numa_init failed wanghaibin
2016-01-07 15:50 ` Tejun Heo
2016-01-11 4:26 ` wanghaibin
2016-01-07 12:38 ` [RFC PATCH 3/4] workqueue: remove the unbind workqueue attr sys_file before unregister the workqueue device wanghaibin
2016-01-07 16:00 ` Tejun Heo
2016-01-11 12:23 ` wanghaibin
2016-01-07 12:38 ` [RFC PATCH 4/4] workqueue: simplify the apply_workqueue_attrs_locked function wanghaibin
2016-01-07 16:07 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56933BE1.1060602@huawei.com \
--to=wanghaibin.wang@huawei.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.huangpeng@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome