From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758343AbcAKHJ4 (ORCPT ); Mon, 11 Jan 2016 02:09:56 -0500 Received: from mx2.suse.de ([195.135.220.15]:44463 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751615AbcAKHJz (ORCPT ); Mon, 11 Jan 2016 02:09:55 -0500 Subject: Re: [PATCH 2/2] scsi: storvsc: Use the specified target ID in device lookup To: "K. Y. Srinivasan" , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, ohering@suse.com, jbottomley@parallels.com, hch@infradead.org, linux-scsi@vger.kernel.org, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, martin.petersen@oracle.com References: <1452318697-25451-1-git-send-email-kys@microsoft.com> <1452318719-25490-1-git-send-email-kys@microsoft.com> <1452318719-25490-2-git-send-email-kys@microsoft.com> From: Hannes Reinecke Message-ID: <56935540.7060304@suse.de> Date: Mon, 11 Jan 2016 08:09:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1452318719-25490-2-git-send-email-kys@microsoft.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/09/2016 06:51 AM, K. Y. Srinivasan wrote: > The current code assumes that there is only one target in device lookup. > Fix this bug. This will alow us to correctly handle hot reomoval of LUNs. > > Signed-off-by: K. Y. Srinivasan > --- > drivers/scsi/storvsc_drv.c | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > index 622f64a..5faf357 100644 > --- a/drivers/scsi/storvsc_drv.c > +++ b/drivers/scsi/storvsc_drv.c > @@ -479,6 +479,7 @@ struct storvsc_scan_work { > struct work_struct work; > struct Scsi_Host *host; > uint lun; > + uint tgt_id; > }; > > static void storvsc_device_scan(struct work_struct *work) > @@ -490,7 +491,7 @@ static void storvsc_device_scan(struct work_struct *work) > wrk = container_of(work, struct storvsc_scan_work, work); > lun = wrk->lun; > > - sdev = scsi_device_lookup(wrk->host, 0, 0, lun); > + sdev = scsi_device_lookup(wrk->host, 0, wrk->tgt_id, lun); > if (!sdev) > goto done; > scsi_rescan_device(&sdev->sdev_gendev); > @@ -541,7 +542,7 @@ static void storvsc_remove_lun(struct work_struct *work) > if (!scsi_host_get(wrk->host)) > goto done; > > - sdev = scsi_device_lookup(wrk->host, 0, 0, wrk->lun); > + sdev = scsi_device_lookup(wrk->host, 0, wrk->tgt_id, wrk->lun); > > if (sdev) { > scsi_remove_device(sdev); > @@ -941,6 +942,7 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb, > > wrk->host = host; > wrk->lun = vm_srb->lun; > + wrk->tgt_id = vm_srb->target_id; > INIT_WORK(&wrk->work, process_err_fn); > schedule_work(&wrk->work); > } > As a side note, are these really 32-bit values? Both the LUN and the target? Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)