From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932923AbcAKMTp (ORCPT ); Mon, 11 Jan 2016 07:19:45 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:42479 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932322AbcAKMTn (ORCPT ); Mon, 11 Jan 2016 07:19:43 -0500 X-Sasl-enc: Zoy7+FSO8SCLJDecCbF2u/NGEsfvsbG0LV3fSZ5lUV9j 1452514782 Subject: Re: [PATCH net] udp: disallow UFO for sockets with SO_NO_CHECK option To: Michal Kubecek , "David S. Miller" References: <20160111065030.F3FFCA0EF1@unicorn.suse.cz> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Nelson, Shannon" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy From: Hannes Frederic Sowa Message-ID: <56939DDC.8030600@stressinduktion.org> Date: Mon, 11 Jan 2016 13:19:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160111065030.F3FFCA0EF1@unicorn.suse.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11.01.2016 07:50, Michal Kubecek wrote: > Commit acf8dd0a9d0b ("udp: only allow UFO for packets from SOCK_DGRAM > sockets") disallows UFO for packets sent from raw sockets. We need to do > the same also for SOCK_DGRAM sockets with SO_NO_CHECK options, even if > for a bit different reason: while such socket would override the > CHECKSUM_PARTIAL set by ip_ufo_append_data(), gso_size is still set and > bad offloading flags warning is triggered in __skb_gso_segment(). > > In the IPv6 case, SO_NO_CHECK option is ignored but we need to disallow > UFO for packets sent by sockets with UDP_NO_CHECK6_TX option. > > Signed-off-by: Michal Kubecek > Tested-by: Shannon Nelson Acked-by: Hannes Frederic Sowa