From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760727AbcAKVHN (ORCPT ); Mon, 11 Jan 2016 16:07:13 -0500 Received: from mail-by2on0053.outbound.protection.outlook.com ([207.46.100.53]:2176 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759135AbcAKVHH (ORCPT ); Mon, 11 Jan 2016 16:07:07 -0500 Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a69-197ff70000000e3e-e3-56941975950b Subject: Re: [PATCH-v2 1/4] tcm_fc: Convert acl lookup to modern get_initiator_node_acl usage To: "Nicholas A. Bellinger" , target-devel References: <1452457724-10629-1-git-send-email-nab@daterainc.com> <1452457724-10629-2-git-send-email-nab@daterainc.com> CC: linux-scsi , lkml , Sagi Grimberg , Christoph Hellwig , Hannes Reinecke , Andy Grover , Vasu Dev , Vu Pham , Nicholas Bellinger From: Bart Van Assche Message-ID: <56941918.80806@sandisk.com> Date: Mon, 11 Jan 2016 13:05:28 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1452457724-10629-2-git-send-email-nab@daterainc.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsWyRoxnkW6p5JQwg/WnzSz2z3rGZLFn0SQm i5WrjzJZXN41h82i+/oONotX51YwWbStPsNocaPtAZtF69K3TBZ7H/lZTD/1kNGB22Pph1XM Hve3H2HymHcy0GP3zQY2j2fTDzN5vN93lc1j8+lqj8+b5AI4orhsUlJzMstSi/TtErgyeo8s ZS54w1bxY+0HpgbGU6xdjJwcEgImEg/aNrB0MXJxCAlsYpTYe3IrG4Szg1Fixpx5bDBVh2+/ gEosZZRYPvEFC0hCWCBeYuOJPkYQW0QgTuLk7p1gtpBApcS+fYfYQRqYBU4xSdzt3gO2j03A SOLb+5lgzbwCGhInzreBxVkEVCU+3uwBi4sKREj82LCEEaJGUOLkzCdAcQ4OTgEnidMrhEBM ZgF7iQdby0AqmAXkJba/ncMMskpC4CurRP/Fv8wQN6hLnFwyn2kCo/AsJJNmIbTPQtK+gJF5 FaNYbmZOcW56aoGhkV5xYl5KZnG2XnJ+7iZGcMRxZe5gXDHJ/BCjAAejEg9vBvuUMCHWxLLi ytxDjBIczEoivBmMQCHelMTKqtSi/Pii0pzU4kOM0hwsSuK81i1qYUIC6YklqdmpqQWpRTBZ Jg5OqQZG0e83i2pUtPqcrJLucN9IXrc6Xi61so1xWscqgWclEqdmXEx+97oq7YzKpFrZKPX6 ThY1o7UOO48fTnY5cIpphrKwyscLNaxlz0P5ryUZrZbzOSqjtP3ZAsvZi++GBbMGrLx/5MeE yD+bIltmph0pWG/d0ry6vDaoRmohw/3EM0HLzILWXtZQYinOSDTUYi4qTgQAqJNiI7QCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOLMWRmVeSWpSXmKPExsXCtZEjRVdCckqYwdoDihb7Zz1jstizaBKT xcrVR5ksLu+aw2bRfX0Hm8WrcyuYLNpWn2G0uNH2gM2idelbJou9j/wspp96yOjA7bH0wypm j/vbjzB5zDsZ6LH7ZgObx7Pph5k83u+7yuax+XS1x+dNcgEcUVw2Kak5mWWpRfp2CVwZvUeW Mhe8Yav4sfYDUwPjKdYuRk4OCQETicO3X7CB2EICixkldk4pALGFBeIlNp7oYwSxRQTiJJ7t eccCUVMpsW/fIfYuRi4OZoETTBJb/h8Ba2YTMJL49n4mWBGvgIbEifNtYAtYBFQlPt7sAYuL CkRI/NiwhBGiRlDi5MwnQHEODk4BJ4nTK4RAwswCthJ35u5mhrDlJba/ncM8gZFvFpKOWUjK ZiEpW8DIvIpRLDczpzg3PbPA0FCvODEvJbM4Wy85P3cTIzjoOSN3MD6daH6IkYmDU6qB0byM 7/xh/S231s6/dGfuLO4Nbm2qHu4qf/9FHOdn4p9ptG59uXqDVKNIp44b3+yJZ/bu5Ky/f+7R vHXdqxm+tUdy8PO+Mu3N2u/mWM6ye8oEyxKBabcX+CVvYtyxcdOJBVzPXR3fpq67cr2vuUBc emMPj9tK5WkvNlr9vcezq09NY8tmmXfKikosxRmJhlrMRcWJAI2jeOAqAgAA X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD004;1:mqsFb39o37yp9FVsIVTFHy5RNz+kLp5rLKFpw8ZHdDrwMlAAXjm6yk42bmoMz1UmuJU5qGDGqzckDq6V8UPcLqIKj85qEWH1jjvcLCwQA+6BRlOjFqVZLIpsWqQtmBwVyUx5UO5sJCgvT6HbYo6C0YWzMruj6tQ5QbVGr73mYnT/VCY1soNAhxTGXiic6F4E0KpqEKbAYnXIvvw0Dz7fJ4I6ZPO8KY2ELuFP6PSEE8BEVpDxja4AHDxvCYrLqPoUgLFT4kxN7F+cO8UuPX1wAqZvcg2PPtWha0VNefv/q1dATc68pSyk6gB9L0j2d+dodmRLDNeo6Ae+dQeG/C5DKgjOfzd+0iBXozfxuD5nFeHLomfo3+9p6Gbk+rxmWpu03mi5A9qkOhFMSsezDEKkv1rmXDzMoVTkSX5OPfZd2SQ= X-Forefront-Antispam-Report: CIP:63.163.107.173;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(24454002)(479174004)(377454003)(189002)(199003)(5001960100002)(586003)(81156007)(106466001)(117636001)(54356999)(65816999)(2906002)(86362001)(11100500001)(23746002)(4001350100001)(92566002)(83506001)(5001770100001)(2950100001)(97736004)(5003600100002)(77096005)(50466002)(5008740100001)(189998001)(50986999)(1220700001)(1096002)(53416004)(65806001)(4326007)(47776003)(76176999)(64126003)(36756003)(65956001)(230700001)(87936001)(69596002)(62816006);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR02MB298;H:milsmgep12.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB298;2:IxOBudLlY2hLt2WmavGKqEvSjS2g2Lt6nNg2B04c0yYbO50TOnFdEo/GAyDoDlHRynehJNYXMRNGqAufQKgi1GydD1o0c8VAa9JqpjCkoV+O3tynFCnL/98OBo0sST6VurgTQ+hPofjUH+/EO+pLsQ==;3:bNE702E8tmroQgvB3j+FGgMMdNp5M5cDYkJY9hQlmfAtAwxlGfoRQx+jjhJKIg+42AgVdZ9uAZ7hJo6OgyCmn5UgbrbIpo/JTpHE0DB94MQDjwZsnT78rnTbkmdOJgffkk7DyhwOhmotVS/IgVMz/1ikPlUHK6NnpRFRvjyvhDPt9jlEf2KvNRR89BBhEz1ABuBSc8qh9hnbUTIxxptNM7MnSTQpqbDussc9Lqsgo+ybCy+h97HVn0GKwADJNvNK2I5cN70Ch1zMy8Bb7Svh/w==;25:XDO1UuPy0eKbCZukUls0giULnxk3Fwi6CigfPt5i6WWMTp7X2DPoa4v/E0trWOXIgR7uGJElrsx+QJQAr2CG8shU0FpajAIMUUvKrFbSgOJ2tLYTq0jh1MweZbYvn6+VeGxQRN4RY9zSCabnsyoKM1t9LlTeyTn1nKDkB7CmbFYiyaXnH3wGjN5KEgDd8iS7r5pr1oBkI1Vjwz1+L3uUneanbx9EBJazyO/eoMKuwbJrY293y1trKV6xF+iHapqm X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BY2PR02MB298; X-MS-Office365-Filtering-Correlation-Id: 283f7da2-4750-421f-2393-08d31acb2804 X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB298;20:J0FK6h4UdHJ3dF05BtzGG9Evog345nDnRYdH4s8SV4jHBL+Ehz7vmop33/9JUjHADq88MHlgzLaZ+1JjdTbu2FQEZApGhg5eRTC13/75JNIdFZTLDOsXcdWaGkizln7p47oTKoAV7JIXuOu0zT2aBpH4uY6wVIbmOhwICZM4nbW/htH5CywTBSQy3D73qIe2ulkTuUaeCl4vg2SE5YmLSsNtrZosWzh2x8+FF+2hdPkSfH7Z3fUY+aJ5rN2XEmQUMuUr+KH4UD3WT6xjLVKaOF1D5ruzK1zmwigjAbEMSUOLKcgl/tiRkP+N5N2GlUb4G66wZjmbJz8bXMBXx1shAvpCCpkZLeiZrACXVnS4wY0vjGzDy0AVWJBqpDuzIzrjGtn/ndTLdOsntLFHm4800TWXib+z7xcL5qP02A+tLGHkAlLQvmPaDzmRHVdkazL2mO5dtSVX8aP77MZZyjU95GWb9+249pwQJBYZMDrsLJbygdK28Pcrn5TqWduxGdKk;4:M/cjBkx8zJghQhDWajfF9Dks52G9csR0ZGozESSzRTxQq8LqnQ+ewsR44CKI47Joy0I1bV9LLPPzDajfYS64kMgDSMOmP8qjEKmZxOk76e3XzNdGgeaHuzYrKNon2tYN/7V+/aVrogZffitHoRvJ1EXrX5hDqC5G4lbg2M2FeOcLPlvj8XDl2iPy6RDUZz6tRIF7vBLaWfyTGauMqsbisUt8yW9EFn+0iQOBMqS0SjSobqiKgRjpTD9nx56lS/7ABmUjqODL2tADYjzyEJWRCv7VBCMTQ53xcTHOrudIRds0JUzkaldbxxSbvzdV0sUPPg8VYT8lPOfCGuxWqlj4wRbcXSTCKe541HgAQQVgR4nkvPWHM2Yy8+hoEHBSfanAa146v8kkgE5zdxDW5zZeDpGXcMdDLtWqLPRoC2AHrlF/k6Q+swthb6zEUxBy/keQ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(13017025)(520078)(13015025)(13018025)(5005006)(10201501046)(3002001);SRVR:BY2PR02MB298;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB298; X-Forefront-PRVS: 0818724663 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR02MB298;23:TNhfNFFKbvBlXz4991LsEdeYleFwx7R5X9BmHg?= =?Windows-1252?Q?tfWDYIrFaJ2UlpCQsv64DaAqPW2PwcSEtB0KyhG7jwb20STqVPB3ixJx?= =?Windows-1252?Q?ZnPyDZXHIHZva1hQ1tv6E11poZe/L4wphQzATIskhlsFaJQNCAFSGKd4?= =?Windows-1252?Q?8sMPJ59zzH9VhuvEqAgsDqdyyP9gCr5zgX5jCmznQB39057d95qKZmEx?= =?Windows-1252?Q?q+b1Gc4MBJvmVbqdrFNJMGPniOjKt7l230jiB5zjQxW8LgH3y3e6RSiV?= =?Windows-1252?Q?CGkUDptNy3kmWy/2E3o45fQ+jyyFyySwDCaIMdiwN7RgOl5/EiI8tbl2?= =?Windows-1252?Q?Sy8Xj6zQNW7XcDFJMgdQNStzHriV4MtPt7ofa0xATOh+Nwz8Yb/R4EYp?= =?Windows-1252?Q?oolxFO1+xrFu7nZf/JCXxh5XpF2NVEpeMFBjjUEmQm274KECwUYpQRRX?= =?Windows-1252?Q?ahA7LJyses4O3PzCTSQfdnPJWkPtDKdd6MasVgWcvV4MZGi/wOHwkME3?= =?Windows-1252?Q?vAsqfPKZZJmkss9sHbmkK+wRWr3WPwt3Am9ULOesXw+ydCarm7wdM2wq?= =?Windows-1252?Q?RaeDOwI52NgSR09KPHEtakF5woLUDkR4p18nbxQnOEDN6LQL31Cb48Ps?= =?Windows-1252?Q?l8Hgufl8t0g0uSB3+lXy5Ai8qi65j9eXqEiG6D3pRsXZlnlCU/uD8y3b?= =?Windows-1252?Q?ybjY8N3JYitzbk7jkwnDiRrMlIT/uW4sdMYr+fRtEQeNuIt4Kp6jLjJ9?= =?Windows-1252?Q?2Flbgqc9vB2KehrtDiZYvjGsH9XuMd3ATcV0Do9W/LhWDy9nn8RYQW9W?= =?Windows-1252?Q?uIpN0NYtKuOynDptggd1yKR1MJp8FtNdyZJl89FfxKDU4bh4kzJ33g6F?= =?Windows-1252?Q?CxrbM5dj4yp7Jn6iwamO0lRjmQQJwX1L0tuNybXLQrxDdJZrwWob6C8Z?= =?Windows-1252?Q?83joeuU/PF7ei97bQXHr2aPJX8RWzA+WuMt8EVHsIOlWm2Bz6e5wVhOw?= =?Windows-1252?Q?OOvOg+5xS1j2H3b6S5RAr2MlMp5bJMCBWZoVA7YRi7p6Zl3ZCunwrfRg?= =?Windows-1252?Q?bbVZbHKPaF8dEUNp1nRgFr7XTspTLVMse6q//dXcdGMHiZ9LKEYNPbu+?= =?Windows-1252?Q?obSZQjeVpHzufRsnKHBHULbhNvkeXX+hpvAfA1wTtKO93UFGWplI2HvO?= =?Windows-1252?Q?ZwFyu932F+esZfjk/kHg53PHbhr3/P1K3512hCFd21wvxMIGsHK16wuJ?= =?Windows-1252?Q?DjKnrrBlriZfO3ILFiroO8ixTn4729BSCJpqM=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB298;5:MSdUavLSMFq4C5NGNv5DSEU2waDEmxL9yo0kpg6DgHd13JKBlRSl2NO56P7sWuXk9qAluF61FTSiwuammPYr7ML+73RWvy1quvgOh2ZUCj96bZvtxsfd+hb7fBWTP4lYbibaSVcYL6sbex/hh6qDjQ==;24:yMXqPBlW/WUewYsghA8/VuCMYmZ/XJFg+BAeWQHOaMVUMcNNNRnr4TcFXXp8rNTRK9anJ5nMm4s2KxZj3xaYqK8IKgPaI6YUVLnUcnwzvyE=;20:arorUIZy3WqPoii1RjBtmzKlSPY+kh1+CkZibywZBZ2LfijRiAtXM44gbB2Tm5HHH5+ZqJYuCrUuOhY18+OIl7RpRpCglvC+fudWrrAy2le95iMMg9hKyMW+COwDEFNAG7KH32Qdh3pA+FJcXq0dhyBBPrqXgTquktJ++/tmNFKnOGHVmn0td8USbrnkWpdXHurEUCPJJ1KZCTLSh7UA/0zgYlHtd5Bk1VGmPN3+1baQp95JEIi97zYmdosWZ49O SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2016 21:07:03.1274 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173];Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB298 X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB139;2:ZlBLtk/cc1AnTq7Ebaupg+9oYIKVextGsg4BE4QIDwmmGzBWxY9b9t0KNyGw3nvg+PhBXDGgcAJGQYMSABjr4HmkQnA2CEJPudm/bzjzmNjzBc9GZD3Xttzl7TWl/6cWIsyLYiHRii1/Ui7nlUsH7Q==;23:Bxr57mSU5P+Rjdoe3IIYR0t1/SqifCv/jch3EI2zgmqDSToEf71Uf12LWiMEpfysMWvD2/UXwcqRWtLWnwnIpz0q1pcodfYQDBuc+jKOadp+DdxR9Jz23wz4yCcK3jYfy3Jlnf4PPs/uS6rRLtTZB52AkrUzdor+gqBVBF0atRXPer6LDrnrdoD70OGlwX4T X-OriginatorOrg: sandisk.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10/2016 12:28 PM, Nicholas A. Bellinger wrote: > This patch does a simple conversion of tcm_fc code to use > proper modern core_tpg_get_initiator_node_acl() lookup using > se_node_acl->acl_kref, and drops the legacy list walk from > ft_acl_get(). > > Note the original lookup also took node_name into account, > but since ft_init_nodeacl() only ever sets port_name for > se_node_acl->acl_group within configfs, this is purely > a mechanical change. Hi Nic, This patch modifies ft_prli_locked() such that the ACL list lookup only happens if FC_SPP_EST_IMG_PAIR has been set by the initiator. That is a behavior change and this has not been mentioned in the patch description. I think the patch description should mention that behavior change and also that it should explain why that behavior change is acceptable - if it is acceptable. Bart.