From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761507AbcAKWL3 (ORCPT ); Mon, 11 Jan 2016 17:11:29 -0500 Received: from mail-bl2on0081.outbound.protection.outlook.com ([65.55.169.81]:7706 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761486AbcAKWLV (ORCPT ); Mon, 11 Jan 2016 17:11:21 -0500 Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a69-60b5e98000000e3e-49-5694287ddabe Subject: Re: [PATCH-for-4.6 1/6] target: Add target_alloc_session() helper function To: "Nicholas A. Bellinger" , target-devel References: <1452458668-11034-1-git-send-email-nab@daterainc.com> <1452458668-11034-2-git-send-email-nab@daterainc.com> CC: linux-scsi , lkml , Sagi Grimberg , "Christoph Hellwig" , Hannes Reinecke , Andy Grover , Vasu Dev , Vu Pham , Nicholas Bellinger From: Bart Van Assche Message-ID: <5694283E.3070401@sandisk.com> Date: Mon, 11 Jan 2016 14:10:06 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1452458668-11034-2-git-send-email-nab@daterainc.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsWyRoxnkW6txpQwg96n/Bb7Zz1jstizaBKT xcrVR5ksLu+aw2bRfX0Hm8WrcyuYLNpWn2G0uNH2gM2idelbJou9j/wspp96yOjA7bH0wypm j/vbjzB5zDsZ6LH7ZgObx7Pph5k83u+7yuax+XS1x+dNcgEcUVw2Kak5mWWpRfp2CVwZG9d/ YSqYJlDReGETcwNjH28XIyeHhICJxJcpfaxdjFwcQgKbGCXeTHnBDuHsYJQ4v/swO0xV44Ob zBCJpYwSvfcmsIEkhAVCJWa2HWcCsUUE4iRO7t7JCGILCVRKXP/yiwmkgVngBJNEV+9CsASb gJHEt/czWUBsXgEtiQnb94DZLAKqEhsPbQezRQUiJH5sWMIIUSMocXLmE6A4BwengJPE6Xlp ICazgL3Eg61lIBXMAvIS29/OAbtNQuAnq8Tvv8dZIG5Qlzi5ZD7TBEbhWUgmzUJon4WkfQEj 8ypGsdzMnOLc9NQCQyO94sS8lMzibL3k/NxNjOCI48rcwbhikvkhRgEORiUe3gz2KWFCrIll xZW5hxglOJiVRHgzGIFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEea1b1MKEBNITS1KzU1MLUotg skwcnFINjHPtD3y+cvoU9/NXqe6a/ySPOt18oqVztf/C/gDfHvtKzZx9bQVR/zVzC9gvaAVW OQtzZOev14maX1Y7mb+Sd/erS0x7NS/vMTG1PecxxdQvSyj6lNMKl4vfe0/XSV1mmGEwjyXE 8vLl20vTog8ssbuVVxulavTldw5rgf47K+mnLNtUZLj8lViKMxINtZiLihMBUvPWzLQCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBLMWRmVeSWpSXmKPExsXCtZEjRddOY0qYQetibYv9s54xWexZNInJ YuXqo0wWl3fNYbPovr6DzeLVuRVMFm2rzzBa3Gh7wGbRuvQtk8XeR34W0089ZHTg9lj6YRWz x/3tR5g85p0M9Nh9s4HN49n0w0we7/ddZfPYfLra4/MmuQCOKC6blNSczLLUIn27BK6Mjeu/ MBVME6hovLCJuYGxj7eLkZNDQsBEovHBTeYuRi4OIYHFjBK3L0xjAUkIC4RKzGw7zgRiiwjE STzb8w4sLiRQKXH9yy8mkAZmgRNMElv+H2EDSbAJGEl8ez8TrIhXQEtiwvY9YDaLgKrExkPb wWxRgQiJHxuWMELUCEqcnPkEKM7BwSngJHF6XhpImFnAVuLO3N3MELa8xPa3c5gnMPLNQtIx C0nZLCRlCxiZVzGK5WbmFOemZxYYGukVJ+alZBZn6yXn525iBIc9Z9QOxusTzQ8xMnFwSjUw BqtxxnWul9nAblA2OXNhrZxcvfympjeMKyV33pP+fJtRZfnVa0IabZz/xeJuXittM2dvZ8jJ Cs89YS5WV1J+4MjaZbMtzDZP3+dntPiB7a9O0ySfoPU/X3lPZ/WbtijoM09vr90dUyOWMlP1 GtttBecWcu3fdUs8MmmPXuunhj+dBy8t/s6kxFKckWioxVxUnAgAK3jzdisCAAA= X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD020;1:rBujlU9owPPipwRVA70QEZEQFiEimTNmMsUvJ7izFO/ZB/C9QS+OdFsg0ittG4l2Xj8700J6BEaFij2kkKFQSvW80jlwFcBmZWl86jKQVfh83TuhiY/qgdael4EIQDU8IMs7v5acgrWCBniTmLxzPDK77KhkPw0NRK3HRCUkqMg/ERRRpX8U+yFaheU9x64Zdc1GX09x3PDV06TYKWt9Lw1qn0BoOUGmeBx6IOQjuIu1MSTFp88iuujtHh5Na4zlGbAiAs61lVFNVefWQWXHyiC76rvRzeQsecpRURZQjxRIGbwJDUs7NtSOjPXPbsJ7sgZuue02tfQCdpCB/nCFuowVo4JKvp48/JHTyfD/G0MJCvL0S+VSp7kdlq4mWnKHxCYOkdUjK+rBrmtWW8ymCw== X-Forefront-Antispam-Report: CIP:63.163.107.173;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(479174004)(377454003)(199003)(189002)(164054003)(24454002)(1096002)(53416004)(65806001)(1220700001)(77096005)(5003600100002)(97736004)(80316001)(5008740100001)(189998001)(50986999)(50466002)(99136001)(230700001)(65956001)(69596002)(87936001)(36756003)(4326007)(64126003)(47776003)(76176999)(81156007)(586003)(54356999)(65816999)(87266999)(106466001)(19580405001)(19580395003)(5001960100002)(92566002)(4001350100001)(5001770100001)(83506001)(23746002)(33656002)(2950100001)(59896002)(2906002)(230783001)(86362001)(309714004);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR02MB298;H:milsmgep12.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB298;2:Ovgd/F+kFBkimlKGa5LsWctrWSIH3ufXRyVWKYAkpU5P2KNx1qo7Sb3YPIbW2XkTDZK2txJTUhP8SGzoZpOyC5ryp2IhTClG2B9R2C7T2wo+Hxbn/YFmuudiULNNzi7LhM29pGvinQstDrSNb0iVvQ==;3:clRLnhD4J9V9DT/ebLMqDZe96wYgR+RPl9adOFfJmrdpGpxoGsD7I/uFSWUCakOJ1LgZAHN38bV+rM1hILCgWQhgnrV/4Tttu+PRtqsBGbb2kQA2AnhpKBzC2QAbiK05JrRNcSruPD0rZDDXQgm6zSly/bG451DI9ZL4aEO4DqjKuqrpigFUQo0UiRLBMCf1KVsTH5Psswph67upvGZQYESZg/IvGvXaZcKx8j1Wy6lpQbdjaO0Eq9/kOG4gIZU8DEeaYOfPUU9o1a7ZqcoAYw==;25:48lhXzHZX0FJYj//3HJqSK9uGw87kWt1Uv7NSRUbcKZEmxHvpCIJKvo9RQYxlDhUad6e63Ef/NIhUSjmUAYEChD3UyPASZXEw40idmyAeR4q2VSmQrfygZzt2cojOEnStvukN4v2j7ab2uopQeYkPVMr1ZpTtB6bspDuep6DIokR18VGWnsAttNB0xp9+4jWn+lBakVxNgHvnSdkKBCXyUF2eGNYSzVnzedNzzlDHu4oAETZiZQaJmNx8ZdZa1FR X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:BY2PR02MB298; X-MS-Office365-Filtering-Correlation-Id: 6dca4442-c2aa-4b9d-ce85-08d31ad41fd1 X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB298;20:K1HKru5Iy8Ba7DFoXZTl/GZubm+MW3lFpxPjL5h4uwJwKjzeJiXDSIBO7fsqp4FVjRwFTnyXUEMb4Z8aVazhRU7L2QR8phKSNm/jgj0coymx91HfjLEYC8YtGNuz4/hhFTGN/+lZ3XHA5i3ho0Dpw8fPqTN1eOeUEQc4nadJKZ/nDimcl/18BHS0wqjsoQoi00+BZBZmWqWutupluKzWF1CyVCEXyOf4Hk9LFI3v1Lbe2FbKnueABJcGOOZaJQK8ZM2r7uEXyvOp03lQ4I3oO6fdOlch763L4zpWQPpkJS9z06LXY2ia35cozMDPUOR9niN+IS1KwXX5C+2kRkCyeHA9QHetNvnovYlrxf07qCc9VcySmfoLKiMFGpHjBDSUIywJSSmVgPi4P2tffPwbRoM0N6+bQXndS3DGSRHMa4qSY1n91o+uRL/YYpC3fiPsuBqSALb2lt19/5xc7f46pOW5zlNCsrsBzLap6QcqHURM0yJ0aJIhQC6Ghgbmoc8e X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(34787635062028); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(13017025)(520078)(13015025)(13018025)(5005006)(10201501046)(3002001);SRVR:BY2PR02MB298;BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB298; X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB298;4:USKM9Ge0J5P1eIOnraje4CLbaPf5eh9/f7Lb61i89BzeLzrTdr7w6PcW4bhD0tWeCAk7Vo7f5oRbX6FfSAX7H3ckLWTwZjoSYRaIZtn8jIRV889yJlR9msB6m4tUBJ5NfNMEm0znX6phyfx/RdRv8plyz2fOfVtZnm+bgYfVdpHxf1IHgJKSGEcxab0oMFBOZMK5SfpmZs5g+YwoqyPn8Wft0uNSyQU/xncvvi+eHpcXYzILIIR9x4b5blWo2XyMyV4k07GQhyZpPM0I2Ad804JNLkwHKTXpLkiA2J/vz95RQ7DMZ2AeYL7VieNVxaVbEGRFid/+HozK0mtPzYNdbwEB4BL2liAA5hWyUz/S+KhlMkDEZzJWi3VXBCAfmY9BJAZt0ABMlaqdQFcbBBsjOL+oM8jawFInFCTGRdw/eErtBteyYzzCl27X5TU1+NrU3eCrUWEo6i3lBfnvnubyVaapzvAQbhwDDXqTiDpROVk= X-Forefront-PRVS: 0818724663 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR02MB298;23:HA1GBj6ddtFfFAtiTVXVmSxGNtZysI7IsfkYc1?= =?Windows-1252?Q?6VOmFpmzhki+KW35nORpujW962L9ZIhWAUs7T37y0qlpMoYnRVlWMTAB?= =?Windows-1252?Q?SXOEDHl5DU1RZdZkDrvugupR3vwAeFn3O13L7en0hanSxh+gS/jMacjq?= =?Windows-1252?Q?04XmZvtZpxdMMT/BLRyFgCeKIfcotum04AGaipFE+JGWslHExgcZTp1Y?= =?Windows-1252?Q?W6Zg0I1pqsLx9JAXunUX5IQ/VdwH7+7wt4Pw7yeijw6iwObI8sQJAR8f?= =?Windows-1252?Q?SaVIfHbt2TTHTE4E4+RQX5/CdwoPKknltK4oVUO9WZImWmkiVjIE7OoI?= =?Windows-1252?Q?vpH9BwRJ7OlPAgnOUs3ggqaDRGTrQqFrwd1xvGdQryxW/O5RMcsoBL4f?= =?Windows-1252?Q?NEGNNO09TH8ZuOdoUQlLxpkViXKgQdz/EAA0WN6gmIzyGd0w+HSr93xU?= =?Windows-1252?Q?XFJjtpDJLjD5e3w103DUpn4IMTstOmC8Jl4Tyy8iae+LqkrWxEYf1l1R?= =?Windows-1252?Q?RlMZnrP8qzIND6DckAAojOd/3UnKWZIbDTtVbkH0iQSA0BLToMicV+vT?= =?Windows-1252?Q?EWyS4ZXqvMDZD/QTcwsK/KZpucnj/7q41RjiP6y5AyDFrFxoB3XMkAKx?= =?Windows-1252?Q?KTpQrAOu/Ki+1eJQ1112ly3G2zXL1OLd1ny09udQe0GLYpFqSucleQbC?= =?Windows-1252?Q?EKuuuDnJ7qVXqCIKZ/yJYRldVh4U3Cqw1GkRxCZN5Z2Rx1eAvpd1OkjU?= =?Windows-1252?Q?2MI4ltWzfTcAQ7jxn6abeGHs/4w+ckUHXP9xKxrG/7lYe87SUpjIZxOH?= =?Windows-1252?Q?nwp2eaAAq5Ee41gSzoDJdcTEZudj7Wej24yJBDyhRSWMJ3izTiIXkojf?= =?Windows-1252?Q?rzbX+QZHRtaLSu4SoI9MpRm+6Xtf97VX+zDCCs8Mei0l5QKmj1XWNu9N?= =?Windows-1252?Q?Sj+v5Rbx0iB+51MpuLa7JsjnlH1Ry4BHghhH1NZm1H68rkHc18LyBxH9?= =?Windows-1252?Q?Gnbd8J5q3zklhUVr0PEEZgKjg4n/zm4ILSHRLWG4isTGDCsbTHjvdI04?= =?Windows-1252?Q?BmjVVbIzkHN1IaCFjKAGEb0mVhAgsqhaK5/OiSRbhPt/OPn+3bTwEZv7?= =?Windows-1252?Q?kUkMZKKeYif9Gt2pcU/WbGl6tehSdlJHK3rCp1TRyaEdnihvnU9wBp8S?= =?Windows-1252?Q?D1nqgUk2HC4U34k1gGMG9VOGFj4ZG01bTgAXnOFpigIhwH1DcRbmzwvc?= =?Windows-1252?Q?uX6eAgW1Y3yMMS1kJbyhjHMn8IVZFhBLCtV3Xvlj/5YAWsH3qmhzCned?= =?Windows-1252?Q?ObmLTQ3SKJOD8O8Z5yphskC96atuQqwvos0s7Xl3lOb0d8mbdjnKFBoB?= =?Windows-1252?Q?Z9eS5ctVRXGFN7GRGvk4NWHdavk/xYqufC32PAwMir4z2BI3qyiNa2VI?= =?Windows-1252?Q?8RD8BM+AYJHEz28E4j?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB298;5:Kkjwh6+tkHZzOM5epAorTs6YiIurzj7b77rny3C9W2mKf8Z+OkOdkL7uKsgafr+CeNX3vwkJxYlrrqavcG7dXwPF0IYv92cuDQFSwjRXtcNST5ev0APg2rj63PQLMVerTvmc/0VfJOS/BbTpzVh3hw==;24:qilAgDv71GRUxpP++pclUcoahUKFn46gwkOETBhvRZkMeuIiss2so8FmYPXC4sWpOzW0rgZ7kvLrh9fwDgTWQmbrFccTCVe1F+Un79XVG/o=;20:v3JSg43M/t4bv5TJwNUfN5Ciz95JtyC8V0Kw6JrJX3SHAyqDUrujD5ZS2/ImwRUHEyys4i3TrrAgi2tH5NbQ4ZHP7myUgsT3ZSK0mUDs2+aIiCN/WFka1Gs1Rcc5W3aH6jrotIsqpqC6hu2YVn/2ILY2n3GDKWxMQaBsIK6nQxRnqIVqXoAhGNKcwp4yvAmIgmJBRlRWBkGDZOXkMZuzfFMbaPIv+q5iFMAP5pJGcbJjsiENGRkSUvwOV7/US6Wn SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2016 22:11:14.5032 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173];Helo=[milsmgep12.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB298 X-Microsoft-Exchange-Diagnostics: 1;BY2PR02MB1702;2:zmtAJfkbOA2JoEZhhsa5ic8RwCdlb7x8Z/ZdAK+Mis088u+8yU+yNtavDKEH7z3i5MyyZKJbm5V1a6kSi+YdDmO+a8BsBE9xuGwS7lU0FnfVqxX6DFrJifqSl9WwH1KeyrMPZqH3N7Bxfwes4gWX3Q==;23:ZH0DY3YFp7PouZYgHEOA+EobOVv/+fzmo8XEwqqPTmidMtUagoIYqRaIbqgbYl1JKy2CBphbyW2zi0sQ85/OqCGgqwZhJ6XB6Mfrk/EubBctCq77bv7MY4dl7nt+RFqa9D6+Wi7w+FQyepVjw+gJCphehHk7rp4lTftVzz6nNFzlhAe4RkndbvtQ0/Vl/Gp+ X-OriginatorOrg: sandisk.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/10/2016 12:44 PM, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger > > Based on HCH's original patch, this adds a full version to > support percpu-ida tag pre-allocation and callback function > pointer into fabric driver code to complete session setup. > > Reported-by: Christoph Hellwig > Cc: Sagi Grimberg > Cc: Christoph Hellwig > Cc: Hannes Reinecke > Cc: Andy Grover > Signed-off-by: Nicholas Bellinger > --- > drivers/target/target_core_transport.c | 55 ++++++++++++++++++++++++++++++++++ > include/target/target_core_fabric.h | 6 ++++ > 2 files changed, 61 insertions(+) > > diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c > index c5035b9..fd4404f6 100644 > --- a/drivers/target/target_core_transport.c > +++ b/drivers/target/target_core_transport.c > @@ -374,6 +374,61 @@ void transport_register_session( > } > EXPORT_SYMBOL(transport_register_session); > > +struct se_session * > +target_alloc_session(struct se_portal_group *tpg, > + unsigned int tag_num, unsigned int tag_size, > + enum target_prot_op prot_op, > + const char *initiatorname, void *private, > + int (*callback)(struct se_portal_group *, > + struct se_session *, void *)) Please use a more descriptive name instead of "callback", e.g. "init_session". > +{ > + struct se_session *sess; > + > + if (tag_num != 0 && !tag_size) { > + pr_err("target_alloc_session called with percpu-ida tag_num:" > + " %u, but zero tag_size\n", tag_num); > + return ERR_PTR(-EINVAL); > + } > + if (!tag_num && tag_size) { > + pr_err("target_alloc_session called with percpu-ida tag_size:" > + " %u, but zero tag_num\n", tag_size); > + return ERR_PTR(-EINVAL); > + } Please combine the above two tests into a single test, e.g. !!tag_num != !!tag_size or (bool)tag_num != (bool)tag_size. Thanks, Bart.