From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761973AbcALBX5 (ORCPT ); Mon, 11 Jan 2016 20:23:57 -0500 Received: from muin.pair.com ([209.68.1.55]:59819 "EHLO muin.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761412AbcALBXy (ORCPT ); Mon, 11 Jan 2016 20:23:54 -0500 Subject: Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults To: Mark Brown Cc: "Maciej S. Szmigiero" , Fabio Estevam , "alsa-devel@alsa-project.org" , Nicolin Chen , Xiubo Li , Liam Girdwood , "linuxppc-dev@lists.ozlabs.org" , linux-kernel References: <5677107C.60904@maciej.szmigiero.name> <20160111140038.GC6588@sirena.org.uk> <5693B7CC.8000905@maciej.szmigiero.name> <20160111145430.GE6588@sirena.org.uk> <5693CE21.8010009@tabi.org> <20160111161225.GJ6588@sirena.org.uk> From: Timur Tabi Message-ID: <569455AA.4060907@tabi.org> Date: Mon, 11 Jan 2016 19:23:54 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:42.0) Gecko/20100101 Firefox/42.0 SeaMonkey/2.39 MIME-Version: 1.0 In-Reply-To: <20160111161225.GJ6588@sirena.org.uk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark Brown wrote: > regcache handles this fine, it's perfectly happy to just go and allocate > the cache as registers get used (this is why the code that's doing the > allocation exists...). What is causing problems here is that the first > access to the register is happening in interrupt context so we can't do > a GFP_KERNEL allocation for it. Considering how small and not-sparse the SSI register space is, would using REGCACHE_FLAT be appropriate?