From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761759AbcALOTI (ORCPT ); Tue, 12 Jan 2016 09:19:08 -0500 Received: from mail-wm0-f54.google.com ([74.125.82.54]:38437 "EHLO mail-wm0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752583AbcALOTG (ORCPT ); Tue, 12 Jan 2016 09:19:06 -0500 Message-ID: <56950B4D.3030707@linaro.org> Date: Tue, 12 Jan 2016 14:18:53 +0000 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org CC: andy.gross@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , linux-kernel@vger.kernel.org, Stephen Boyd Subject: Re: [PATCH 2/5] arm64: dts: apq8016-sbc: move sdhci node under soc node References: <1452606358-24569-1-git-send-email-srinivas.kandagatla@linaro.org> <1452606412-24659-1-git-send-email-srinivas.kandagatla@linaro.org> <18094818.3Fy0P66y0u@wuerfel> In-Reply-To: <18094818.3Fy0P66y0u@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/01/16 14:00, Arnd Bergmann wrote: > On Tuesday 12 January 2016 13:46:52 Srinivas Kandagatla wrote: >> To be consistent with other nodes move sdhci node under the soc node, >> rather than using lable references. >> >> Signed-off-by: Srinivas Kandagatla >> > > Maybe remove the label as well if you are no longer using it? Label "sdhc_1" in this case is used in aliases node. > My understanding so far was qcom specific dt want to use hierarchical dt nodes in the board files, but this brings the question of should we delete all the unused labels. IMO, some unused labels are harmless and would give more consistency to the reader, removing them might not add great value. Andy/Stephen, any comments? --srini > Arnd >