From: Kevin Locke <kevin@kevinlocke.name>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
ibm-acpi-devel@lists.sourceforge.net
Cc: "Johannes Stezenbach" <js@sig21.net>,
"Pali Rohár" <pali.rohar@gmail.com>,
linux-kernel@vger.kernel.org,
"Fabio D'Urso" <fabiodurso@hotmail.it>,
platform-driver-x86@vger.kernel.org,
"Pavel Machek" <pavel@ucw.cz>,
"Darren Hart" <dvhart@infradead.org>
Subject: Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight
Date: Tue, 12 Jan 2016 10:11:00 -0800 [thread overview]
Message-ID: <569541B4.1020905@kevinlocke.name> (raw)
In-Reply-To: <1452614830.376787.489968026.5FAEDB86@webmail.messagingengine.com>
On 01/12/2016 08:07 AM, Henrique de Moraes Holschuh wrote:
> On Mon, Jan 11, 2016, at 19:12, Johannes Stezenbach wrote:
>> I can confirm this, my x230 has both. FWIW, BIOS hotkey
>> Fn+Space cycles through off, dim backlight, full backlight
>> and full thinklight. /sys/class/leds/tpacpi::thinklight/brightness
>> can be read (showing either 0 or 255) but writes are ignored.
>> Dito for /proc/acpi/ibm/light.
>
> We likely need to integrate better (future work) the new backlight
> control with the thinklight control and the firmware interface in the
> x230.
>
> Is the ACPI AML for fn+space readable enough, or is it trapping directly
> into SMM? Because if it interacts with the traditional higher-level
> ACPI AML we already use to talk to the thinklight (and now to the
> backlight), it should be relatively easy to fix the driver to better
> support the x230.
I looked through the DSDT and SSDT AML on the T430 (which also has both
a keyboard backlight and ThinkLight) and couldn't deduce which method
was being invoked for Fn+Space or an analog to MLCG/MLCS for the
ThinkLight. However, that may be due to my inexperience interpreting
AML. I'll keep looking/learning.
I've posted the files online if anyone else has time/interest to take a
look: https://kevinlocke.name/misc/t430-acpi/
Best regards,
Kevin
next prev parent reply other threads:[~2016-01-12 18:17 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 18:46 Pali Rohár
2015-12-27 23:14 ` Henrique de Moraes Holschuh
2015-12-28 14:48 ` Pali Rohár
2015-12-30 22:28 ` Pali Rohár
2016-01-06 8:45 ` Pali Rohár
2016-01-09 17:36 ` Henrique de Moraes Holschuh
2015-12-30 22:27 ` [PATCH v2] " Pali Rohár
2016-01-04 20:04 ` Darren Hart
2016-01-04 20:26 ` Pali Rohár
2016-01-04 20:40 ` Darren Hart
2016-01-04 20:51 ` Pali Rohár
2016-01-04 21:42 ` Darren Hart
2016-01-09 17:34 ` Henrique de Moraes Holschuh
2016-01-04 20:12 ` [PATCH] " Pavel Machek
2016-01-04 20:23 ` Pali Rohár
2016-01-04 20:40 ` Pali Rohár
2016-01-09 17:39 ` Henrique de Moraes Holschuh
2016-01-09 17:46 ` Henrique de Moraes Holschuh
2016-01-11 19:04 ` Darren Hart
2016-01-11 19:28 ` Henrique de Moraes Holschuh
2016-01-11 20:03 ` Pali Rohár
2016-01-11 21:12 ` Johannes Stezenbach
2016-01-12 16:07 ` Henrique de Moraes Holschuh
2016-01-12 16:23 ` [ibm-acpi-devel] " Yves-Alexis Perez
2016-01-12 16:35 ` Johannes Stezenbach
2016-01-12 17:56 ` Henrique de Moraes Holschuh
2016-01-12 22:07 ` Johannes Stezenbach
2016-01-12 18:11 ` Kevin Locke [this message]
2016-01-12 18:20 ` [ibm-acpi-devel] " Henrique de Moraes Holschuh
2016-01-12 18:36 ` Kevin Locke
2016-01-12 16:04 ` Henrique de Moraes Holschuh
2016-01-12 21:58 ` Pavel Machek
2016-01-13 8:54 ` Pali Rohár
2016-01-13 19:07 ` Pavel Machek
2016-01-13 19:10 ` Pavel Machek
2016-01-21 8:57 ` Pali Rohár
2016-01-11 22:44 ` [ibm-acpi-devel] " Yves-Alexis Perez
2016-01-12 16:59 ` Darren Hart
2016-01-12 17:51 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569541B4.1020905@kevinlocke.name \
--to=kevin@kevinlocke.name \
--cc=dvhart@infradead.org \
--cc=fabiodurso@hotmail.it \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=js@sig21.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®