From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753959AbcAMCAX (ORCPT ); Tue, 12 Jan 2016 21:00:23 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:58931 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753921AbcAMCAS (ORCPT ); Tue, 12 Jan 2016 21:00:18 -0500 X-AuditID: cbfec7f5-f79b16d000005389-1b-5695afafa0a3 Subject: Re: [PATCH v3 2/2] power: add documentation for ACT8945A's charger DT bindings To: Wenyou Yang , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala References: <1452586185-818-1-git-send-email-wenyou.yang@atmel.com> <1452586185-818-3-git-send-email-wenyou.yang@atmel.com> Cc: Javier Martinez Canillas , Lee Jones , Nicolas Ferre , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <5695AFAD.4030307@samsung.com> Date: Wed, 13 Jan 2016 11:00:13 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-version: 1.0 In-reply-to: <1452586185-818-3-git-send-email-wenyou.yang@atmel.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsVy+t/xq7rr108NM3h2W9ti0pP3zBYTV05m tuh/s5DV4tyrlYwW137PYLN4/cLQ4v7Xo4wWmx5fY7W4vGsOm8Xn3iOMFkuvX2Sy+Ha5md1i wvS1LBate4+wW5zeXWJx+9cGFgcBjzXz1jB6LPi1lcXjcl8vk8ff2a3MHjtn3WX3WLn8C5vH 5hVaHptWdbJ53Lm2B8hbUu/Rt2UVo8fnTXIBPFFcNimpOZllqUX6dglcGb9vP2UraBOp6Nty n7GBcZ1AFyMnh4SAicSmT1sZIWwxiQv31rN1MXJxCAksZZTY9nwClPOUUWLy6+lsIFXCApES 2xcdZQVJiAg8ZpKYffIyUxcjB1BVrcTcfgWQOLPAQ0aJie8Ps4I0sAkYS2xevoQNYoWcRG/3 JBYQm1dAS2LP359MIDaLgKrEopl/GUHmiApESCzakQlRIijxY/I9FpAwp4CLxO239SAms4Ce xP2LWiAVzALyEpvXvGWewCg4C0nDLISqWUiqFjAyr2IUTS1NLihOSs810itOzC0uzUvXS87P 3cQIicivOxiXHrM6xCjAwajEw2swY2qYEGtiWXFl7iFGCQ5mJRHekpVAId6UxMqq1KL8+KLS nNTiQ4zSHCxK4rwzd70PERJITyxJzU5NLUgtgskycXBKNTDO8madqlzPui8iqHKjGZNq0UVm +847qhkFOe+i3x6fGXD3ffulFb7bhNWz9ldwm25o/bwm7LOdY1fLiobaqkNGf50LZ9+PrXuc ff5z08Ftf/xPumpxqy0SPOSwZ//ex6F5j9Yd6W4OYpkWI7mzMkjurqfu6onPXVqX3NvNnPRk yu5r2rVXt+9TYinOSDTUYi4qTgQAJhhL6MQCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.01.2016 17:09, Wenyou Yang wrote: > This patch adds documentation for the DT bindings of the charger > subdevice of ACT8945A MFD. > > Signed-off-by: Wenyou Yang > --- > > Changes in v3: None > Changes in v2: None > > .../devicetree/bindings/power/act8945a-charger.txt | 34 ++++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/act8945a-charger.txt > > diff --git a/Documentation/devicetree/bindings/power/act8945a-charger.txt b/Documentation/devicetree/bindings/power/act8945a-charger.txt > new file mode 100644 > index 0000000..868e0164 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/act8945a-charger.txt > @@ -0,0 +1,34 @@ > +Device-Tree bindings for charger of Active-semi ACT8945A Multi-Function Device > + > +Required properties: > + - compatible: "active-semi,act8945a-charger" > + - active-semi,chglev-gpio = Specifies a gpio that uses to select > + the charge current level. active-semi,chglev-gpios See: Documentation/devicetree/bindings/gpio/gpio.txt > + > +Optional properties: > + - active-semi,battery_temperature: Indicates if it is allowed to check > + the battery temperature. If it is missing, assume the battery temperature > + is not allowed to check. Here and in rest of properties - no underscores but hyphens. The name suggests that this is a value... but this is a boolean? > + - active-semi,input_voltage_threshold: unit: mV; > + Specifies the charger's input over-voltage threshold value; > + The value can be: 6600, 7000, 7500, 8000; default: 6600 I think adding units suffix in binding is preferred. so "-microvolt"? Best regards, Krzysztof > + - active-semi,precondition_timeout: unit: minutes; > + Specifies the charger's PRECONDITION safety timer setting value; > + The value can be: 40, 60, 80, 0; If 0, it means to disable this timer; > + default: 40. > + - active-semi,total_timeout: unit: hours; > + Specifies the charger's total safety timer setting value; > + The value can be: 3, 4, 5, 0; If 0, it means to disable this timer; > + default: 3. > + > +Example: > + > + charger { > + compatible = "active-semi,act8945a-charger"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_charger_chglev>; > + active-semi,chglev-gpio = <&pioA 12 GPIO_ACTIVE_HIGH>; > + active-semi,input_voltage_threshold = <6600>; > + active-semi,precondition_timeout = <40>; > + active-semi,total_timeout = <3>; > + }; >