From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754834AbcAMQp2 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 13 Jan 2016 11:45:28 -0500
Received: from mail-wm0-f52.google.com ([74.125.82.52]:36872 "EHLO
	mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754267AbcAMQpV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 13 Jan 2016 11:45:21 -0500
Subject: Re: [PATCH-v2 3/4] target: Fix change depth se_session reference
 usage
To: "Nicholas A. Bellinger" <nab@daterainc.com>,
        target-devel <target-devel@vger.kernel.org>
References: <1452457724-10629-1-git-send-email-nab@daterainc.com>
 <1452457724-10629-4-git-send-email-nab@daterainc.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Sagi Grimberg <sagig@mellanox.com>, Christoph Hellwig <hch@lst.de>,
        Hannes Reinecke <hare@suse.de>, Andy Grover <agrover@redhat.com>,
        Vasu Dev <vasu.dev@linux.intel.com>, Vu Pham <vu@mellanox.com>,
        Nicholas Bellinger <nab@linux-iscsi.org>
From: Sagi Grimberg <sagig@dev.mellanox.co.il>
Message-ID: <56967F1C.2070408@dev.mellanox.co.il>
Date: Wed, 13 Jan 2016 18:45:16 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1452457724-10629-4-git-send-email-nab@daterainc.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> Also, it includes a bug-fix for iscsi-target where explicit
> session shutdown in lio_tpg_shutdown_session() was not
> obtaining se_portal_group->session_lock for both cases,
> plus drop pointless wrapper.

It'd be better to move this to a dedicated patch IMO.

The other split I was going to suggest was target_get_session()
which you already took care of...