From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755797AbcAMTGL (ORCPT ); Wed, 13 Jan 2016 14:06:11 -0500 Received: from bear.ext.ti.com ([192.94.94.41]:34462 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbcAMTGJ (ORCPT ); Wed, 13 Jan 2016 14:06:09 -0500 Subject: Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery To: "H. Nikolaus Schaller" References: <20160111202421.GA12777@atomide.com> <20160112000917.GC12777@atomide.com> <417BBA32-A7DC-40CD-8A6B-EA910B1C9C13@goldelico.com> <001346CD-CF31-4FEF-B406-B89EEBDFA063@goldelico.com> <56966558.1070608@ti.com> <569669C5.2070200@ti.com> <20160113164856.GF12777@atomide.com> <5696896F.4090309@ti.com> <20160113180006.GJ12777@atomide.com> <2B99611A-5D2E-4D17-A17D-0150516109FD@goldelico.com> <56969800.5010206@ti.com> CC: Tony Lindgren , Grygorii Strashko , Laxman Dewangan , =?UTF-8?Q?Beno=c3=aet_Cousson?= , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , linux-omap , , LKML , Marek Belisko , =?UTF-8?Q?Gra=c5=bevydas_Ignotas?= , Keerthy From: Nishanth Menon X-Enigmail-Draft-Status: N1110 Message-ID: <5696A002.6050402@ti.com> Date: Wed, 13 Jan 2016 13:05:38 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/13/2016 12:44 PM, H. Nikolaus Schaller wrote: > > Am 13.01.2016 um 19:31 schrieb Nishanth Menon : > >> On 01/13/2016 12:08 PM, H. Nikolaus Schaller wrote: >> [...] >> >>>> OK. So are we sure the TWL driver will never have to toggle this pin? >>> >>> After studying the Palmas TRM it appears that this pin just should be "high" >>> to be able to write to RTC and some scratchpad register. If the Palmas OTP >>> is programmed to use gpio7 as msecure input. >> >> Thanks for digging it up. we dont use the scratchpad, but in some cases >> where SoC cold reset is involved, those registers may store additional >> information. > > I remember a similar thing from omap3-twl4030 where the boot source is stored > so that a warm reboot searches there. But I don#t know if the OMPAP5 Boot ROM > is using that. > I believe that nonsense of OMAP ROM accessing PMIC stopped with OMAP3. I dont believe OMAP4 or any later generation processors does any PMIC access anymore - they instead make assumptions about specific voltage levels they will work on (So called OPP_BOOT) instead of assuming specific PMIC they will work with.. >>> Since the scratchpad is not used we can permanently enable msecure. Which >>> means that we must somehow get the driving output to be "1". >>> >>> This can be either done by >>> * a gpio with pull-up - switched to input mode as I proposed, or >> >> I think you intended to suggest to do a mux to gpio with just pinmux >> pull? > > Yes. > >> The internal pull on padconf is very weak >> - for typical needs like >> these, it is rather suggested to stick with real GPIO drive to prevent >> conditions like noise interference(for example). > > > well, on OMAP5 pull up/down are astonishingly strong :) > 100-250ľA. Which translated roughly to 7 .. 18 kOhm @ 1.8V logic. > So a noise source must be coupled by an impedance in the 1 kOhm range. > This is quite rare. So I would not worry about that. > Interesting. I did not know that, and have'nt dug at people to confirm that either :). An internal feedback I got some time back on AM57 (not OMAP5) - context was that we were discussing if an external pull up resistor was needed for a GPIO button: "Internal pull-ups are relatively weak (ranging to 100kOhm or higher) and are good for avoiding higher leakage due to floating input level, and may not be sufficient for valid logic 1/0 depending on what else is connected on the board. If a signal must absolutely be pulled to a valid logic 1 or 0 for system functionality, then an external pull should be used." Anyways... will let Tony decide where he wants to go on this.. -- Regards, Nishanth Menon