From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750962AbcAOFBx (ORCPT ); Fri, 15 Jan 2016 00:01:53 -0500 Received: from smtp-out-224.synserver.de ([212.40.185.224]:1466 "EHLO smtp-out-067.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750717AbcAOFBv (ORCPT ); Fri, 15 Jan 2016 00:01:51 -0500 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 9960 Subject: Re: [PATCH] iio: adc: Add TI ADS1015 ADC driver support To: Michael Welling , Daniel Baluta References: <1452788708-3003-1-git-send-email-daniel.baluta@intel.com> <20160114165133.GA20246@deathstar> Cc: jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, lucas.demarchi@intel.com, eibach@gdsys.de, linux@roeck-us.net From: Lars-Peter Clausen Message-ID: <5697D511.7040301@metafoo.de> Date: Thu, 14 Jan 2016 18:04:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160114165133.GA20246@deathstar> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/14/2016 05:51 PM, Michael Welling wrote: > On Thu, Jan 14, 2016 at 06:25:08PM +0200, Daniel Baluta wrote: >> The driver has sysfs readings with runtime PM support for power saving. >> It also offers buffer support that can be used together with IIO software >> triggers. >> > > It should be noted that the hwmon driver subsystem has support for this device. > > http://lxr.free-electrons.com/source/drivers/hwmon/ads1015.c > > The driver could likely be removed if this is accepted into iio. > The hwmon subsystem has an iio wrapper driver. If we do this we should instantiate the hwmon bridge for such drivers by default, so that the userspace ABI is kept intact. And of course we'd also need backwards compatibility for those horrible devicetree bindings. - Lars