From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751610AbcAOBlH (ORCPT ); Thu, 14 Jan 2016 20:41:07 -0500 Received: from mr213138.mail.yeah.net ([223.252.213.138]:46464 "EHLO mr213138.mail.yeah.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750905AbcAOBlF (ORCPT ); Thu, 14 Jan 2016 20:41:05 -0500 Subject: Re: [PATCH 2/3] mmc: sdhci-pci: Add platform tuning callback for amd hs200 mode To: Ulf Hansson , Wan Zongshun References: <1450802408-16354-1-git-send-email-vincent.wan@amd.com> <1450802408-16354-2-git-send-email-vincent.wan@amd.com> Cc: linux-mmc , Wan Zongshun , Borislav Petkov , "linux-kernel@vger.kernel.org" , Huang Rui From: Wan Zongshun Message-ID: <56984DAE.2060200@iommu.org> Date: Fri, 15 Jan 2016 09:38:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1koWUFPN1dZCBgUCR5ZQVZLVUpDQkJCQkNKQ0NLSkNMQkNDV1kJDhceCF lBWSgrPSQrOigoJDI1JDM#Oj8#KUFLVUtANiMkIj4oJDI1JDM#Oj8#KUFLVUtAKy8pJCI#KCQyNS QzPjo*PilBS1VLQDg0LjUvKSIkODVBS1VLQCk#PDI0NSQ6KDI6QUtVS0ArKTQtMjU4PiQoMzo1PD M6MkFLVUtAPyI1OjYyOCQyKyQ1NCQyNSQzPjo*PilBS1VLQDYuNy8yJCk4Ky8kPzI9PT4pPjUvJD I1JDM#Oj8#KUFJVUtAMiskSEskNjI1Li8#JDg1LyRLJE5LQUtVS0AyKyRKJDYyNS4vPiQ4NS8kSy RKS0FLVUtAMiskLzQ*OiIkODUvJEskSktLQUtVS0AyKyROJDYyNS4vPiQ4NS8kSyRKS0FLVUtAMi skSiQzNC4pJDg1LyRLJEpLS0FLVUtAKC45MT44LyQvND86IiQ4NS8kSyRKS0tBS1VLQCguOTE#OC 8kTiQ2MjUuLz4kODUvJEskSktBS1VLQCguOTE#OC8kSiQzNC4pJDg1LyRLJEpLS0FLVUtAPTUkNj oiJE9KQiQzNzEkSiRLQ0tIS09BS1VISEA9KyQpPiQ9LCQzNzEkS0NLSEtNQVZMVU5APTUkKC45JD 41LDQpPygkMzcxJEpLS0lLSkFLVUlDQCguOSQ#QUpVTk5APTUkOTIvTCQzNzEkS0xKSUtJQUhVSk 5APTUkNjoiJE9KQiQzNzEkSSRLQ0tIS09BS1VLWQY+ X-HM-Sender-Digest: e1kSHx4VD1lBWUc6Nxg6Cio5OjozGRBPTCIsDhYQQi4KCTFVSlVKT05J Q0lJS09DQ09LVTMWGhIXVQ0MOxIUFhYOVRQJHEVZV1kMHhlZQR0aFwgeV1kIAVlBSE5JTDdXWRIL WUFZSUpLVUpIVUJMVUpNQ1kG X-HM-Tid: 0a5242f12fd07d8a634dc1019b5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> >> But I also met trouble in sdhci_execute_tuning of sdhci.c, I have to suppose >> only sdhci_pci_platform_execute_tuning is returning -EPERM(current code, >> my assumption is right), so that those vendor that has no >> slot->platform_execute_tuning could be skipped and go next standard >> tuning process. >> >> If you have better idea for my requirement, please correct me. > > sdhci needs to become a set of library functions. > > Typically the mmc_host_ops ->execute_tuning() callback for sdhci, > should be assigned to a default function, unless the sdhci variant has > assigned it to something else. > > Yes, I realize that it requires core changes to sdhci to allow this. > Although it's necessary do this conversion as I won't accept any more > changes for sdhci that doesn't move the code into this direction. > Ulf, Then Can you point me what's my next step for submitting tuning workaround for AMD emmc4.5 driver? What your mean is you will change sdhci-pci-core.c to a core and library function? And then I can implement a AMD specific emmc-pci driver call to those libs? > Kind regards > Uffe > >> >> Thanks! >> Wan Zongshun. >> >> --- >> drivers/mmc/host/sdhci-pci-core.c | 23 +++++++++++++++++++++++ >> drivers/mmc/host/sdhci-pci.h | 1 + >> drivers/mmc/host/sdhci.c | 3 ++- >> 3 files changed, 26 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c >> index 01c5723..e7b2bbe 100644 >> --- a/drivers/mmc/host/sdhci-pci-core.c >> +++ b/drivers/mmc/host/sdhci-pci-core.c >> @@ -905,8 +905,19 @@ static int amd_probe(struct sdhci_pci_chip *chip) >> return 0; >> } >>