From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A5BEC433FE for ; Mon, 14 Nov 2022 06:34:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235797AbiKNGed (ORCPT ); Mon, 14 Nov 2022 01:34:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235615AbiKNGea (ORCPT ); Mon, 14 Nov 2022 01:34:30 -0500 Received: from out30-57.freemail.mail.aliyun.com (out30-57.freemail.mail.aliyun.com [115.124.30.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C22211150 for ; Sun, 13 Nov 2022 22:34:29 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R281e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046050;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0VUiKOlR_1668407663; Received: from 30.97.48.62(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VUiKOlR_1668407663) by smtp.aliyun-inc.com; Mon, 14 Nov 2022 14:34:25 +0800 Message-ID: <5699ed28-bdad-f9ab-44b6-e957c00745f9@linux.alibaba.com> Date: Mon, 14 Nov 2022 14:34:27 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 14/18] mfd: sprd-sc27xx-spi: Replace irqchip mask_invert with unmask_base To: Aidan MacDonald , lee@kernel.org Cc: mani@kernel.org, cristian.ciocaltea@gmail.com, wens@csie.org, tharvey@gateworks.com, cw00.choi@samsung.com, krzysztof.kozlowski@linaro.org, brgl@bgdev.pl, mazziesaccount@gmail.com, orsonzhai@gmail.com, zhang.lyra@gmail.com, jernej.skrabec@gmail.com, samuel@sholland.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev References: <20221112151835.39059-1-aidanmacdonald.0x0@gmail.com> <20221112151835.39059-15-aidanmacdonald.0x0@gmail.com> From: Baolin Wang In-Reply-To: <20221112151835.39059-15-aidanmacdonald.0x0@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/12/2022 11:18 PM, Aidan MacDonald wrote: > Remove use of the deprecated mask_invert flag. Inverted mask > registers (where a '1' bit enables an IRQ) can be described more > directly as an unmask register. > > Signed-off-by: Aidan MacDonald LGTM. Thanks. Reviewed-by: Baolin Wang > --- > drivers/mfd/sprd-sc27xx-spi.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c > index d05a47c5187f..a4a9b81a952b 100644 > --- a/drivers/mfd/sprd-sc27xx-spi.c > +++ b/drivers/mfd/sprd-sc27xx-spi.c > @@ -181,11 +181,10 @@ static int sprd_pmic_probe(struct spi_device *spi) > ddata->irq_chip.name = dev_name(&spi->dev); > ddata->irq_chip.status_base = > pdata->irq_base + SPRD_PMIC_INT_MASK_STATUS; > - ddata->irq_chip.mask_base = pdata->irq_base + SPRD_PMIC_INT_EN; > + ddata->irq_chip.unmask_base = pdata->irq_base + SPRD_PMIC_INT_EN; > ddata->irq_chip.ack_base = 0; > ddata->irq_chip.num_regs = 1; > ddata->irq_chip.num_irqs = pdata->num_irqs; > - ddata->irq_chip.mask_invert = true; > > ddata->irqs = devm_kcalloc(&spi->dev, > pdata->num_irqs, sizeof(struct regmap_irq),