From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752688AbcAQOQX (ORCPT ); Sun, 17 Jan 2016 09:16:23 -0500 Received: from vi37-28-154-113.vibiznes.pl ([37.28.154.113]:60739 "EHLO vps-vb.mhejs.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752235AbcAQOQW (ORCPT ); Sun, 17 Jan 2016 09:16:22 -0500 Message-ID: <569BA225.8070509@maciej.szmigiero.name> Date: Sun, 17 Jan 2016 15:16:05 +0100 From: "Maciej S. Szmigiero" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: Timur Tabi CC: Fabio Estevam , "alsa-devel@alsa-project.org" , Nicolin Chen , Xiubo Li , Liam Girdwood , Mark Brown , "linuxppc-dev@lists.ozlabs.org" , linux-kernel Subject: Re: [PATCH 3/3] ASoC: fsl_ssi: remove register defaults References: <5677107C.60904@maciej.szmigiero.name> <5693B4C1.4060400@maciej.szmigiero.name> <569AD8A7.7080803@maciej.szmigiero.name> <569ADC0D.2000807@tabi.org> <569AE7D1.6050607@maciej.szmigiero.name> <569B23A8.3010006@tabi.org> In-Reply-To: <569B23A8.3010006@tabi.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.01.2016 06:16, Timur Tabi wrote: > Maciej S. Szmigiero wrote: >> This is because (at least according to the datasheet) imx21-class SSI >> registers end at CCSR_SSI_SRMSK (no SACC{ST,EN,DIS} regs), so >> reading them for cache initialization may not be safe. >> >> Also, a "MXC 91221 only" comment before these regs in FSL tree >> (drivers/mxc/ssi/registers.h) seems to confirm that these registers >> aren't present at least on some SSI (or SoC) models. > > Can't we just mark them as precious or something, so that we don't have to have two structures? Looks like it can be done with just one static regmap config struct used then as template - I will post updated patch. Maciej