From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932068AbcARKNy (ORCPT ); Mon, 18 Jan 2016 05:13:54 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:51083 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753966AbcARKNu (ORCPT ); Mon, 18 Jan 2016 05:13:50 -0500 X-AuditID: cbfee68f-f793a6d000001364-92-569cbadc0e87 Message-id: <569CBADA.20508@samsung.com> Date: Mon, 18 Jan 2016 19:13:46 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Shawn Lin , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: dw_mmc: remove "disable-wp" property References: <1453110604-8169-1-git-send-email-shawn.lin@rock-chips.com> In-reply-to: <1453110604-8169-1-git-send-email-shawn.lin@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42JZI2JSqHtn15wwgw2XLCwu75rDZnHkfz+j xZ0n61ktjq8Nd2DxuHNtD5vH31n7WTw+b5ILYI7isklJzcksSy3St0vgymhfs529YLlIxfT/ xQ2MCwW6GDk5JARMJB5/62KCsMUkLtxbz9bFyMUhJLCCUeL/sy2sMEU9b6exQySWMkr82TeF FcJ5wCix4fphFpAqXgENietTHrKB2CwCqhLNpz+xg9hsAjoS278dB1shKhAm8WDdXlaIekGJ H5PvgfWKCPhJbN2xFayXWcBa4uePVrAaYQE7iVX3GsHmCAm4S7x+9xvM5hTwkHi58hRQPQdQ vZ7E/YtaEK3yEpvXvGUGuU1CYBW7xNlnU6DuEZD4NvkQC0i9hICsxKYDzBCPSUocXHGDZQKj 2CwkF81CmDoLydQFjMyrGEVTC5ILipPSi4z1ihNzi0vz0vWS83M3MQLj5/S/Z/07GO8esD7E KMDBqMTDO+P87DAh1sSy4srcQ4ymQEdMZJYSTc4HRmleSbyhsZmRhamJqbGRuaWZkjjvQqmf wUIC6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoYnVfy7Jy3+1rYjvzkZs6GS71inu38vzovdnFf /nx4vl2b7d+jET2mxcfvrwhZnBc85530Q+XltWqn1O9Ne3p50osDC6rr7d5d5RO5+qHjyYXN R1Zo7quQv3DiwpuMqA1pUYen64RaRDSuesh3MUNrgvHKObpF5ixX75W6xiht3T73ySaZt6X2 q5VYijMSDbWYi4oTAQDQy5iaAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsVy+t9jAd07u+aEGWz/YGxxedccNosj//sZ Le48Wc9qcXxtuAOLx51re9g8/s7az+LxeZNcAHNUA6NNRmpiSmqRQmpecn5KZl66rZJ3cLxz vKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtA2JYWyxJxSoFBAYnGxkr4dpgmhIW66FjCNEbq+ IUFwPUYGaCBhDWNG+5rt7AXLRSqm/y9uYFwo0MXIySEhYCLR83YaO4QtJnHh3nq2LkYuDiGB pYwSf/ZNYYVwHjBKbLh+mAWkildAQ+L6lIdsIDaLgKpE8+lPYN1sAjoS278dZwKxRQXCJB6s 28sKUS8o8WPyPbBeEQE/ia07toL1MgtYS/z80QpWIyxgJ7HqXiPYHCEBd4nX736D2ZwCHhIv V54CqucAqteTuH9RC6JVXmLzmrfMExgFZiHZMAuhahaSqgWMzKsYJVILkguKk9JzDfNSy/WK E3OLS/PS9ZLzczcxgmP0mdQOxoO73A8xCnAwKvHwOpydHSbEmlhWXJl7iFGCg1lJhDd4/Zww Id6UxMqq1KL8+KLSnNTiQ4ymwCCYyCwlmpwPTB95JfGGxiZmRpZG5oYWRsbmSuK8tZciw4QE 0hNLUrNTUwtSi2D6mDg4pRoY597e9+D/SpENnYa/pWI7bGLKH/D2TpqxS+T3sktZj80N9b7r V4dmsy/Mbi0SjWBe63lTm7d0oRvLoo49YksTa9PentJ7mfdg7/n0NCsm+ZWNi2o+chzXCNrE v33ye4Xt1g9+1PXO2Si2V0g4hLFDUH9a0JqL5VZfyhx+K0sUdzTMOb/8K+t9JZbijERDLeai 4kQAZZCq0+cCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Shawn. On 01/18/2016 06:50 PM, Shawn Lin wrote: > dw_mmc already use mmc_of_parse to get disable-wp, > so we remove it from dw_mmc. And dw_mci_slot_of_parse > will not be removed as well. Yes, it's already used "mmc_of_parse". You can see "slot quirks 'disable-wp' is deprecated". Since the properties was included in slot regs before using "mmc_of_parse". So we chosen to print the message "deprecated" to prevent the developer's confusion. At this time, actually, i think there are no developers who confused this. I will consider more about this patch. Thanks! Best Regards, Jaehoon Chung > > Signed-off-by: Shawn Lin > --- > > drivers/mmc/host/dw_mmc.c | 43 ------------------------------------------- > 1 file changed, 43 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index fddbcb6..8687554 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2493,47 +2493,6 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id) > return IRQ_HANDLED; > } > > -#ifdef CONFIG_OF > -/* given a slot, find out the device node representing that slot */ > -static struct device_node *dw_mci_of_find_slot_node(struct dw_mci_slot *slot) > -{ > - struct device *dev = slot->mmc->parent; > - struct device_node *np; > - const __be32 *addr; > - int len; > - > - if (!dev || !dev->of_node) > - return NULL; > - > - for_each_child_of_node(dev->of_node, np) { > - addr = of_get_property(np, "reg", &len); > - if (!addr || (len < sizeof(int))) > - continue; > - if (be32_to_cpup(addr) == slot->id) > - return np; > - } > - return NULL; > -} > - > -static void dw_mci_slot_of_parse(struct dw_mci_slot *slot) > -{ > - struct device_node *np = dw_mci_of_find_slot_node(slot); > - > - if (!np) > - return; > - > - if (of_property_read_bool(np, "disable-wp")) { > - slot->mmc->caps2 |= MMC_CAP2_NO_WRITE_PROTECT; > - dev_warn(slot->mmc->parent, > - "Slot quirk 'disable-wp' is deprecated\n"); > - } > -} > -#else /* CONFIG_OF */ > -static void dw_mci_slot_of_parse(struct dw_mci_slot *slot) > -{ > -} > -#endif /* CONFIG_OF */ > - > static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) > { > struct mmc_host *mmc; > @@ -2590,8 +2549,6 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) > if (host->pdata->caps2) > mmc->caps2 = host->pdata->caps2; > > - dw_mci_slot_of_parse(slot); > - > ret = mmc_of_parse(mmc); > if (ret) > goto err_host_allocated; >