From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756464AbcARTMo (ORCPT ); Mon, 18 Jan 2016 14:12:44 -0500 Received: from mail-ob0-f177.google.com ([209.85.214.177]:35712 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756140AbcARTMl (ORCPT ); Mon, 18 Jan 2016 14:12:41 -0500 Subject: Re: [PATCH 2/4] hw_random: bcm63xx-rng: add device tree support To: =?UTF-8?Q?=c3=81lvaro_Fern=c3=a1ndez_Rojas?= , linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, jogo@openwrt.org, cernekee@gmail.com References: <1453021437-12531-2-git-send-email-noltari@gmail.com> From: Florian Fainelli Message-ID: <569D3927.3030401@gmail.com> Date: Mon, 18 Jan 2016 11:12:39 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1453021437-12531-2-git-send-email-noltari@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 17/01/2016 01:03, Álvaro Fernández Rojas a écrit : > Adds device tree support for BCM6368, which seems to be the only BCM63xx with > bcm63xx-rng support. > > Signed-off-by: Álvaro Fernández Rojas > --- > drivers/char/hw_random/bcm63xx-rng.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/char/hw_random/bcm63xx-rng.c b/drivers/char/hw_random/bcm63xx-rng.c > index c303f30..38553f0 100644 > --- a/drivers/char/hw_random/bcm63xx-rng.c > +++ b/drivers/char/hw_random/bcm63xx-rng.c > @@ -130,10 +130,17 @@ static int bcm63xx_rng_probe(struct platform_device *pdev) > return 0; > } > #ifdef CONFIG_OF here? > +static const struct of_device_id bcm63xx_rng_of_match[] = { > + { .compatible = "brcm,bcm6368-rng", }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, bcm63xx_rng_of_match); > + > static struct platform_driver bcm63xx_rng_driver = { > .probe = bcm63xx_rng_probe, > .driver = { > .name = "bcm63xx-rng", > + .of_match_table = bcm63xx_rng_of_match, of_match_ptr(bcm63xx_rng_of_match) would be nice here as well since we can still build this driver for BCM63XX which is not OF enabled. Other than that: Reviewed-by: Florian Fainelli -- Florian