From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756701AbcASEIE (ORCPT ); Mon, 18 Jan 2016 23:08:04 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:41715 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755726AbcASEIB (ORCPT ); Mon, 18 Jan 2016 23:08:01 -0500 X-AuditID: cbfee68e-f793c6d00000136c-43-569db69e6fc2 Message-id: <569DB69C.5060003@samsung.com> Date: Tue, 19 Jan 2016 13:07:56 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Shawn Lin , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] Convert dw_mci_pltfm_prepare_command into a library call References: <1453174787-13536-1-git-send-email-shawn.lin@rock-chips.com> In-reply-to: <1453174787-13536-1-git-send-email-shawn.lin@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjkeLIzCtJLcpLzFFi42JZI2JSrDtv29wwg9VdehaXd81hszjyv5/R 4s6T9awWx9eGO7B43Lm2h83j76z9LB6fN8kFMEdx2aSk5mSWpRbp2yVwZRxfuom5YCl7xftP zawNjM9Zuxg5OSQETCT27TnIBmGLSVy4tx7I5uIQEljBKHF//wdmmKJny6azQiSWMkp0bHvM COE8YJQ4OWELkMPBwSugJbH0iCWIySKgKrFlTwhIL5uAjsT2b8eZQGxRgTCJB+v2gi3mFRCU +DH5HguILSLgJ7F1x1awI5gFrCV+/mgFqxEWCJY4tfs1WFxIwEPi7uQL7CA2p4CnxJ7jP1hA VjEL6Encv6gF0SovsXnNW2aQyyQE1rFL3F3dAtbLIiAg8W3yIbB6CQFZiU0HoN6SlDi44gbL BEaxWUgumoUwdRaSqQsYmVcxiqYWJBcUJ6UXGekVJ+YWl+al6yXn525iBEbP6X/P+nYw3jxg fYhRgINRiYf3hePcMCHWxLLiytxDjKZAR0xklhJNzgfGaF5JvKGxmZGFqYmpsZG5pZmSOG+C 1M9gIYH0xJLU7NTUgtSi+KLSnNTiQ4xMHJxSDYxFO2z8szdzFV2cci6gfQZjodlqR0Ex+/cP 99/k8eZaPrtsqfQ82eKMhqm7F50uTCgUDdAxTGw4fttPTMhmy7Kv7yYfU1bzL50tKx3CWsXD Vux9XUtlwrR3hW+zLvlcNn3G2L95+sV3AowdHyui71Qn8jZlTih4s2b7+l8b12l1BQjqPVP7 q6XEUpyRaKjFXFScCACGjHtAmQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMIsWRmVeSWpSXmKPExsVy+t9jAd152+aGGbxapmlxedccNosj//sZ Le48Wc9qcXxtuAOLx51re9g8/s7az+LxeZNcAHNUA6NNRmpiSmqRQmpecn5KZl66rZJ3cLxz vKmZgaGuoaWFuZJCXmJuqq2Si0+ArltmDtA2JYWyxJxSoFBAYnGxkr4dpgmhIW66FjCNEbq+ IUFwPUYGaCBhDWPG8aWbmAuWsle8/9TM2sD4nLWLkZNDQsBE4tmy6VC2mMSFe+vZuhi5OIQE ljJKdGx7zAjhPGCUODlhC5DDwcEroCWx9IgliMkioCqxZU8ISC+bgI7E9m/HmUBsUYEwiQfr 9oLN5BUQlPgx+R4LiC0i4CexdcdWNhCbWcBa4uePVrAaYYFgiVO7X4PFhQQ8JO5OvsAOYnMK eErsOf6DBWQVs4CexP2LWhCt8hKb17xlnsAoMAvJhlkIVbOQVC1gZF7FKJFakFxQnJSea5SX Wq5XnJhbXJqXrpecn7uJERyhz6R3MB7e5X6IUYCDUYmHd4L93DAh1sSy4srcQ4wSHMxKIrwT 5gOFeFMSK6tSi/Lji0pzUosPMZoCQ2Ais5Rocj4weeSVxBsam5gZWRqZG1oYGZsrifPuuxQZ JiSQnliSmp2aWpBaBNPHxMEp1cA4yUim7EeqcBTzB5729K5f3ac/LJPYefRA2/Qkl7boJ9Z/ fiw7/3te2E4L39LFPtYPnfV8601zUtVqLP9o1aRNvO8+071kqdtOYRWfdy8vuP/5EzpjJ5fO xumr/bw2O+9/cfvZRy7NjAe3lB4fqE9OVCpb/aXnhV2ad+FO67ONk/Y8Mg9/0VqhxFKckWio xVxUnAgAioW9feYCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Shawn. On 01/19/2016 12:39 PM, Shawn Lin wrote: > This patchset expose dw_mci_pltfm_prepare_command towards to > library call and remove the redundant code from dw_mmc-rockchip. > Meanwhile we make dw_mmc-exynos to call it instead of changing cmdr > in its variant drivers. Thanks for your effort. Right way. We need to try that remove the hook for operation. Looks good to me. After check, i will pick these. Also other your patch. :) Best Regards, Jaehoon Chung > > > > Shawn Lin (3): > mmc: dw_mmc: expose dw_mci_pltfm_prepare_command > mmc: dw_mmc-rockchip: remove prepare_command hook > mmc: dw_mmc-exynos: wrapper prepare_command > > drivers/mmc/host/dw_mmc-exynos.c | 4 ++-- > drivers/mmc/host/dw_mmc-pltfm.c | 3 ++- > drivers/mmc/host/dw_mmc-pltfm.h | 2 +- > drivers/mmc/host/dw_mmc-rockchip.c | 9 ++------- > 4 files changed, 7 insertions(+), 11 deletions(-) >