From: Sudeep Holla <sudeep.holla@arm.com>
To: Zhong Kaihua <zhongkaihua@huawei.com>, robh+dt@kernel.org
Cc: pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
catalin.marinas@arm.com, will.deacon@arm.com,
xuyiping@hisilicon.com, xuwei5@hisilicon.com,
bintian.wang@huawei.com, haojian.zhuang@linaro.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, puck.chen@hisilicon.com,
Sudeep Holla <sudeep.holla@arm.com>,
w.f@huawei.com, dan.zhao@hisilicon.com,
kong.kongxinwei@hisilicon.com
Subject: Re: [PATCH V3 1/3] arm64: dts: Add Hi6220 gpio configuration nodes
Date: Tue, 19 Jan 2016 13:37:19 +0000 [thread overview]
Message-ID: <569E3C0F.3040603@arm.com> (raw)
In-Reply-To: <1453200681-26406-1-git-send-email-zhongkaihua@huawei.com>
On 19/01/16 10:51, Zhong Kaihua wrote:
> arm64: dts: Add Hi6220 gpio configuration nodes
>
> Signed-off-by: Zhong Kaihua <zhongkaihua@huawei.com>
> Kong Xinwei <kong.kongxinwei@hisilicon.com>
>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> .../devicetree/bindings/gpio/gpio-hi6220.txt | 23 +
> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 +
> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 259 +++++++++
> arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi | 607 +++++++++++++++++++++
> 4 files changed, 890 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> create mode 100644 arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> new file mode 100644
> index 0000000..a9cbf21
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt
> @@ -0,0 +1,23 @@
> +Hisilicon Hi6220 GPIO controller bindings
> +
> +Required properties:
> + - compatible: "arm,pl061","arm,primecell"
> + - gpio-controller: Marks the device node as a GPIO controller.
> + - #gpio-cells: Should be 2. See gpio.txt in this directory for a
> + description of the cells format.
> + - interrupt-controller: Mark the device node as an interrupt controller
> +
Why do you need extra binding document here as the compatible is same as
[1] ? You can extend that if required and add example there IMO.
--
Regards,
Sudeep
[1] Documentation/devicetree/bindings/gpio/pl061-gpio.txt
next prev parent reply other threads:[~2016-01-19 13:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 10:51 Zhong Kaihua
2016-01-19 10:51 ` [PATCH V3 2/3] arm64: dts: add Hi6220 pinctrl " Zhong Kaihua
2016-01-19 10:51 ` [PATCH V3 3/3] arm64: dts: add Hi6220 spi " Zhong Kaihua
2016-01-19 12:25 ` [PATCH V3 1/3] arm64: dts: Add Hi6220 gpio " Wei Xu
2016-01-19 13:37 ` Sudeep Holla [this message]
2016-01-22 8:59 ` Zhong Kaihua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569E3C0F.3040603@arm.com \
--to=sudeep.holla@arm.com \
--cc=bintian.wang@huawei.com \
--cc=catalin.marinas@arm.com \
--cc=dan.zhao@hisilicon.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=haojian.zhuang@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=puck.chen@hisilicon.com \
--cc=robh+dt@kernel.org \
--cc=w.f@huawei.com \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=zhongkaihua@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome