From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758461AbcATJ42 (ORCPT ); Wed, 20 Jan 2016 04:56:28 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:38375 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758438AbcATJ4V (ORCPT ); Wed, 20 Jan 2016 04:56:21 -0500 Subject: Re: [PATCH] NVMe: init nvme queue before enabling irq To: Wenbo Wang , Johannes Thumshirn , Wenbo Wang References: <1453265860-31080-1-git-send-email-mail_weber_wang@163.com> <20160120090931.GO2742@c203.arch.suse.de> Cc: "keith.busch@intel.com" , "axboe@fb.com" , "Wenwei.Tao" , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" From: Sagi Grimberg Message-ID: <569F59B1.3040207@dev.mellanox.co.il> Date: Wed, 20 Jan 2016 11:56:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> If it can cause a kernel panic shouldn't it go through stable then as well? > > Sorry, not quite understand this comment. > The "reset process" is the nvme device reset process (performed by nvme_reset_work()) triggered by device fail condition. > During normal boot up, nvmeq door bell is initialized in nvme_alloc_queue() which happens before enabling irq, so there is no error. > During nvme device reset process, nvme_alloc_queue() is skipped and the race condition exists. I think what Johannes meant was that this patch should include a "CC: stable@vger.kernel.org" tag.