mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthias Fend <matthias.fend@emfend.at>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	Umang Jain <uajain@igalia.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] media: dt-bindings: imx283: add clock-noncontinuous
Date: Wed, 17 Dec 2025 13:26:05 +0100	[thread overview]
Message-ID: <569a9b01-2a95-4e1d-819e-f6445ee55375@emfend.at> (raw)
In-Reply-To: <2c7e7b96-f9f4-4875-9aab-0f3dcaf6baf2@kernel.org>

Hi Krzysztof,

thanks for your feedback.

Am 17.12.2025 um 13:03 schrieb Krzysztof Kozlowski:
> On 17/12/2025 08:06, Matthias Fend wrote:
>> Add the optional clock-noncontinuous endpoint property that allows enabling
>> MIPI CSI-2 non-continuous clock operations.
>>
>> Signed-off-by: Matthias Fend <matthias.fend@emfend.at>
>> ---
>>   Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
>> index e4f49f1435a5c2e6e1507d250662ea6ecbf3c7dc..a91695f5618767ac851e5bc72b347a21da77c52d 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
>> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
>> @@ -59,6 +59,7 @@ properties:
>>                     - const: 3
>>                     - const: 4
>>   
>> +          clock-noncontinuous: true
> 
> Drop, it's already there via referenced schema.
> 
>>             link-frequencies: true
>>   
>>           required:
>> @@ -99,6 +100,7 @@ examples:
>>                   imx283: endpoint {
>>                       remote-endpoint = <&cam>;
>>                       data-lanes = <1 2 3 4>;
>> +                    clock-noncontinuous;
> 
> And updating example just for this is rather churn.

I thought it was worth the change because the example now reflects the 
original (before this series) behavior of the sensor.

Do you think I should remove the entire commit from the series?

Thanks
  ~Matthias

> 
>>                       link-frequencies = /bits/ 64 <360000000>;
>>                   };
>>               };
>>
> 
> 
> Best regards,
> Krzysztof


  reply	other threads:[~2025-12-17 12:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-17  7:05 [PATCH 0/3] drivers: media: imx283 extensions Matthias Fend
2025-12-17  7:06 ` [PATCH 1/3] media: dt-bindings: imx283: add clock-noncontinuous Matthias Fend
2025-12-17 12:03   ` Krzysztof Kozlowski
2025-12-17 12:26     ` Matthias Fend [this message]
2025-12-17 12:31       ` Krzysztof Kozlowski
2025-12-17  7:06 ` [PATCH 2/3] media: i2c: imx283: add support for non-continuous MIPI clock mode Matthias Fend
2025-12-30 10:44   ` Kieran Bingham
2026-01-01 18:09     ` Matthias Fend
2025-12-17  7:06 ` [PATCH 3/3] media: i2c: imx283: implement {g,s}_register Matthias Fend
2025-12-17 11:54   ` Dave Stevenson
2025-12-17 12:21     ` Matthias Fend
2025-12-17 12:42       ` Kieran Bingham
2025-12-17 14:02         ` Matthias Fend
2025-12-17 15:39           ` Dave Stevenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=569a9b01-2a95-4e1d-819e-f6445ee55375@emfend.at \
    --to=matthias.fend@emfend.at \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=uajain@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®