From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 006613EC2CD for ; Tue, 30 Jun 2026 10:12:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782814337; cv=none; b=t/P98sjfciY2FApBhd8fIrQgLyTIRFZz/+uhGIbq9UK8h4PWG3Y+XonemJmuHGeaXQ06w4JjKgMwE8TLTh6+jtcO3zc0rjXJTihYykly4kt3Bd5rMzVxmH/SWtp6360hplAavaXY6UbcQymJBcK8fd+9LHxXNoae8f8hpRrToOA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782814337; c=relaxed/simple; bh=tPLcI+u4fdxJg60JZI60iQH6kOjAxDYL6VS6LtHZG0k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YDxB0Mmch22RW92TKgQNkZuCxj/GPBeSHuNVumLErqUggGoDO/STpFT6JO6saIQ1zqzybAvwH2Ts+e0VeOqESoaLjSymVQRt+oimhdQ6/W1+09AhKINcBrmZbq+x7uHwIBGGAhMGeu6ldwB0O3tU6h30VHzdvi56hxH7d4nwzSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pxV1hPM4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=gA2dWIYb; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pxV1hPM4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="gA2dWIYb" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65U9mxI41613433 for ; Tue, 30 Jun 2026 10:12:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= vJf/wa7yHc74ZgiFrSpsTI1e/uwDjYdMLcBdWjlk2y8=; b=pxV1hPM4z+/Eenok CkSla+QBI/JXhSz8IqWd/sRx5IIj7E/JQ3+DtbJC9NjT5nC3LCm2PP5MWjCr3nI6 PexfBWgZ91/Uu99YdoAZyaRCHKVUn9tC2d2fG3o7T/BGnUWj7QyOnJKVX9AYIkmd QUZinQ1FUTE2H6VFk3zzlqft6XnaRmQ35u2jprQ8U+6MUjRVLTjB4AfwVJayWha1 HumNO2NHyHvVjPBiYo2NnY6JZewl94a7PPhmSaA3yQejZerYbMTjq++Cy7eB3zYG VsHB81TQ6Z0NGE4RpuzyNwmtdwGsSVVDCJ4SPMfVhAtQFe2j2AFAGP+Jd7ZkKz/J KXBIlQ== Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3x1cu8db-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 30 Jun 2026 10:12:14 +0000 (GMT) Received: by mail-vs1-f69.google.com with SMTP id ada2fe7eead31-738a934c5daso62973137.0 for ; Tue, 30 Jun 2026 03:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782814334; x=1783419134; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=vJf/wa7yHc74ZgiFrSpsTI1e/uwDjYdMLcBdWjlk2y8=; b=gA2dWIYb6m7m206BS18v/MSnwR1EU6LCf+wEey6NsvHL2H/rWAMpQohMzes1t/6Ih6 dHSpHi0vpJ6ZdW/5XgUXRosBrvnsA8q6oKNhxXuXyKplck6rmJn9L08OetJ5y0844PE1 qKO2WMSorjvSxCtnmLUm0e1OxIbhiCKKCyhbsxT25ohR4T8U1t2L8rCmLGwvOrRtgXJM HJN0mX3lx+X4KQNcLPdXIsb3whmccHZl9Jy+Bo+/y4eUrpa1jBcK2M/Y2VTFv22KRXw8 0kpMx3lM4OJvX/UaDEjeql0Vtjdc4IoR2retBAnXtgcRg/1VE5BIEryhlYQd/q9iicok BEXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782814334; x=1783419134; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=vJf/wa7yHc74ZgiFrSpsTI1e/uwDjYdMLcBdWjlk2y8=; b=nl+cJ9pNUcOLKeJ05p97nGuuzHJZKN2uXdUvDFjjngK20SVa3wKevuV16uE2Y+l4uJ h/CXCTEK08mhvr0d9Hj/z0+4hBgmSwHzxOgyF8zIVoKTGSioL4KpcCAM84jaSo/Iy9ea tO/4kVZNDkgzzxHKTidtC4UxN4PnjhqCpKbJ4SWCMYYmNKIvze5hFIanYZrlWG/JyoWL VJpmVAYLHZA/x3yI1Txkx3daNSKeliMbiT9jC7xyTs67cYs0Kze6mBwc0lAaJlS/CFWc Ow/7f8OyOyxclLiU2yfI8QuzD6y4MnUeRFvExT50zgI5HcXmE7321HHMg4m5gwuja6tx DFWw== X-Forwarded-Encrypted: i=1; AHgh+RosoZvsv1sVa4JFv1VTbomMX5JPhJFW5NLMM80SHf21zgblX2RYVj4iC2Z8daSj5zCJwJByjiLI4NFqMQo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+8l5uKLg32kxEt+/ncFgD56KEqo4kd8zVwRZy+g1FfqwTxwEk PHyBfj8rTlIbxX66/pI8AmM7y7KijbiLM6i2EnEo8Diut1r1Kd3QY+d5Fs88Zcb9gjPNuxWs5w2 d5ZXxcqLG+HNivMqIu3SFn9wxtq7+gu/bHRlTm72VJTrbqRBceYKd35Zhoxb18s4FRtg= X-Gm-Gg: AfdE7cm+dNiub7CUSl+7SuPDtC6FwFcXjgIDE8acllBXnkAxaX2dI1kgcP6xXClfoTN W0xRYR8npCQ8YULOud9CIOh0AXVezAW7pjLTpnhREkYJqODKn3cWI7vWoRjcwvwwVJ/IIbbIxOa Y2CFxKQj/0Nl6xXs7DTIC+4kc+hA8DZmyookcPIV5XLICc8VwREyAeR9ZbWMSEAsZT7PPCtMq/c lWHeISI+w+ODA8wb6pn08GhhHLjK4zbul3+8NEzhAyaPjvs/8iG2pgNbWtbwZr03yhBttjCiQ6a iXuHUGVjEbN4Q2t3d6RTeY4dJQEIv/hUIIYBQ1gNJiEyT/t4a0zevJNcz+xbVNB8ImpRPqPhZFn 786u5WxMmp53zwog0DthIoYSSmErdRNqbeHc= X-Received: by 2002:a05:6102:4415:b0:727:36b9:dee with SMTP id ada2fe7eead31-73a397532camr475310137.8.1782814334319; Tue, 30 Jun 2026 03:12:14 -0700 (PDT) X-Received: by 2002:a05:6102:4415:b0:727:36b9:dee with SMTP id ada2fe7eead31-73a397532camr475307137.8.1782814333824; Tue, 30 Jun 2026 03:12:13 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6987c98927csm905223a12.30.2026.06.30.03.12.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jun 2026 03:12:12 -0700 (PDT) Message-ID: <569d7a0a-fbde-4e8b-a148-376e93150dbd@oss.qualcomm.com> Date: Tue, 30 Jun 2026 12:12:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] firmware: qcom: scm: Fix tzmem state on probe retry To: Mukesh Ojha , Bjorn Andersson , Konrad Dybcio , Bartosz Golaszewski , Guru Das Srinagesh , Sibi Sankar , Elliot Berman , Andrew Halaney Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260629141750.996853-1-mukesh.ojha@oss.qualcomm.com> <20260629141750.996853-4-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260629141750.996853-4-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjMwMDA5MSBTYWx0ZWRfX/dqfjmE8SBaK kSMqa+AX45A8iFJ6Qe8wcviyQvu1wlRGldh7cMWJvnA6x38kqIln8sSPc+Ad4hgJDbAl3V93DIh HjyOaE9Njlrx1/HIfZBMbfuou6y/cLAYikA9aseBYgBXaEZ8xpcBAH+Pw5LRlsOn9G8+A01CJ8I fveb3fEM6tSWa5BgCi1n5h5Td1xVdWDg8V/X1iGtkjTHfIyvaGgmPEc57tx8XVaVLPRFfZt/gFx Vdx53Nn4qsEcERJ7pkLlJ4Z40oPwFeElghagHaCGVTNf9ywrYSua0K9XEAxNW3ln0ozQFXMYZSk PmEfrZz0l+AgiNUiux34qP5mJPmHbwACAsrwHGOZL7KR5KYOvkh+mbhNVPyeXoEjc7BKTcttID8 rXsWLRnprgjPUCIQXxNZv6vv+VheiVzsqhc3XUW3pVvLsT0LXi2nLpzQVr8KzK9eDOYpgOIVp7v kOt6nPCkQC0Ahtqjuhw== X-Proofpoint-ORIG-GUID: CyMfXj5ggZmKIV4RMIFR6tt3UtmSgNR4 X-Proofpoint-GUID: CyMfXj5ggZmKIV4RMIFR6tt3UtmSgNR4 X-Authority-Analysis: v=2.4 cv=ftfsol4f c=1 sm=1 tr=0 ts=6a43967e cx=c_pps a=5HAIKLe1ejAbszaTRHs9Ug==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=W7ye19pv6vkr5SR8RCAA:9 a=QEXdDO2ut3YA:10 a=gYDTvv6II1OnSo0itH1n:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjMwMDA5MSBTYWx0ZWRfXzSKD38HXtp9D 0/DZQ7Qf6H2GqOV+d2isYqGY6Gg3K0q7kb/tDwWkbRyhmra9/U1J2TvQyORMpfUOfllztBnluhX mIB3qIR7HktsIAO83ggIcrK6L/5+GXU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-30_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 adultscore=0 spamscore=0 clxscore=1015 malwarescore=0 phishscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606300091 On 6/29/26 4:17 PM, Mukesh Ojha wrote: > qcom_tzmem_enable() returns -EBUSY if called a second time, but this > causes probe retries to fail permanently if a later step in > qcom_scm_probe() defers after qcom_tzmem_enable() has already succeeded. > > Use DO_ONCE() to ensure qcom_tzmem_init() runs exactly once across all > calls in a thread-safe manner. qcom_tzmem_dev is set on every call since > probe retries use the same device pointer. The result of the first > initialisation is cached and returned to every subsequent caller. > > Fixes: 40289e35ca52 ("firmware: qcom: scm: enable the TZ mem allocator") > Signed-off-by: Mukesh Ojha > --- Reviewed-by: Konrad Dybcio Konrad