From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4028AC10F11 for ; Wed, 10 Apr 2019 08:05:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1837520818 for ; Wed, 10 Apr 2019 08:05:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729103AbfDJIFJ (ORCPT ); Wed, 10 Apr 2019 04:05:09 -0400 Received: from mga18.intel.com ([134.134.136.126]:19564 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726494AbfDJIFI (ORCPT ); Wed, 10 Apr 2019 04:05:08 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 01:05:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,332,1549958400"; d="scan'208";a="160338317" Received: from mylly.fi.intel.com (HELO [10.237.72.159]) ([10.237.72.159]) by fmsmga004.fm.intel.com with ESMTP; 10 Apr 2019 01:05:07 -0700 Subject: Re: [PATCH v1] mfd: intel-lpss: Add Intel Comet Lake PCI IDs To: Andy Shevchenko , Lee Jones , linux-kernel@vger.kernel.org References: <20190409151100.16027-1-andriy.shevchenko@linux.intel.com> From: Jarkko Nikula Message-ID: <569fc1f8-241e-ef9b-a097-68329d36add4@linux.intel.com> Date: Wed, 10 Apr 2019 11:05:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190409151100.16027-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/9/19 6:11 PM, Andy Shevchenko wrote: > Intel Comet Lake has the same LPSS than Intel Cannon Lake. > Add the new IDs to the list of supported devices. > > Signed-off-by: Andy Shevchenko > --- > drivers/mfd/intel-lpss-pci.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c > index a67f67c90ec4..50a907f93da9 100644 > --- a/drivers/mfd/intel-lpss-pci.c > +++ b/drivers/mfd/intel-lpss-pci.c > @@ -129,6 +129,19 @@ static const struct intel_lpss_platform_info cnl_i2c_info = { > }; > > static const struct pci_device_id intel_lpss_pci_ids[] = { > + /* CML */ > + { PCI_VDEVICE(INTEL, 0x02a8), (kernel_ulong_t)&spt_uart_info }, > + { PCI_VDEVICE(INTEL, 0x02a9), (kernel_ulong_t)&spt_uart_info }, > + { PCI_VDEVICE(INTEL, 0x02aa), (kernel_ulong_t)&spt_info }, > + { PCI_VDEVICE(INTEL, 0x02ab), (kernel_ulong_t)&spt_info }, > + { PCI_VDEVICE(INTEL, 0x02c5), (kernel_ulong_t)&bxt_i2c_info }, > + { PCI_VDEVICE(INTEL, 0x02c6), (kernel_ulong_t)&bxt_i2c_info }, > + { PCI_VDEVICE(INTEL, 0x02c7), (kernel_ulong_t)&spt_uart_info }, > + { PCI_VDEVICE(INTEL, 0x02e8), (kernel_ulong_t)&bxt_i2c_info }, > + { PCI_VDEVICE(INTEL, 0x02e9), (kernel_ulong_t)&bxt_i2c_info }, > + { PCI_VDEVICE(INTEL, 0x02ea), (kernel_ulong_t)&bxt_i2c_info }, > + { PCI_VDEVICE(INTEL, 0x02eb), (kernel_ulong_t)&bxt_i2c_info }, > + { PCI_VDEVICE(INTEL, 0x02fb), (kernel_ulong_t)&spt_info }, > /* BXT A-Step */ > { PCI_VDEVICE(INTEL, 0x0aac), (kernel_ulong_t)&bxt_i2c_info }, > { PCI_VDEVICE(INTEL, 0x0aae), (kernel_ulong_t)&bxt_i2c_info }, Let's hold a bit. I'd like to double check does the I2C controller use Skylake or Broxton derived input clocks. -- Jarkko