From: Fenghua Yu <fenghuay@nvidia.com>
To: Nirmoy Das <nirmoyd@nvidia.com>, Tony Luck <tony.luck@intel.com>,
Reinette Chatre <reinette.chatre@intel.com>,
x86@kernel.org
Cc: Dave Martin <Dave.Martin@arm.com>,
James Morse <james.morse@arm.com>,
Babu Moger <babu.moger@amd.com>, Ben Horgan <ben.horgan@arm.com>,
Drew Fustini <fustini@kernel.org>,
Thomas Gleixner <tglx@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/resctrl: Report unknown schemata domains
Date: Wed, 18 Nov 2026 15:08:28 -0800 [thread overview]
Message-ID: <569fd2af-47d4-4f9a-8f38-6c368b0466b5@nvidia.com> (raw)
In-Reply-To: <20261118205825.3339003-1-nirmoyd@nvidia.com>
On 11/18/26 12:58, Nirmoy Das wrote:
> A schemata write to an unknown domain returns -EINVAL without setting
> last_cmd_status. The status buffer is cleared before parsing, so reading
> last_cmd_status after the failed write incorrectly reports "ok".
>
> Report the invalid domain before returning -EINVAL, matching the existing
> I/O allocation parser diagnostic.
>
> Fixes: c377dcfbee80 ("x86/intel_rdt: Add diagnostics when writing the schemata file")
> Signed-off-by: Nirmoy Das <nirmoyd@nvidia.com>
> ---
> fs/resctrl/ctrlmondata.c | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Fenghua Yu <fenghuay@nvidia.com>
Thanks.
-Fenghua
> diff --git a/fs/resctrl/ctrlmondata.c b/fs/resctrl/ctrlmondata.c
> index 69123b2a3274804a..2f7db6c669214c3a 100644
> --- a/fs/resctrl/ctrlmondata.c
> +++ b/fs/resctrl/ctrlmondata.c
> @@ -279,6 +279,7 @@ static int parse_line(char *line, struct resctrl_schema *s,
> goto next;
> }
> }
> + rdt_last_cmd_printf("Invalid domain %lu\n", dom_id);
> return -EINVAL;
> }
>
>
> base-commit: 2a93af75384b7e95d62c5a9a39e13573e2170ec5
prev parent reply other threads:[~2026-11-18 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 20:58 Nirmoy Das
2026-11-18 23:08 ` Fenghua Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569fd2af-47d4-4f9a-8f38-6c368b0466b5@nvidia.com \
--to=fenghuay@nvidia.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=ben.horgan@arm.com \
--cc=fustini@kernel.org \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nirmoyd@nvidia.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®