From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbcAUASZ (ORCPT ); Wed, 20 Jan 2016 19:18:25 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:33591 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbcAUASX (ORCPT ); Wed, 20 Jan 2016 19:18:23 -0500 X-AuditID: cbfec7f4-f79026d00000418a-40-56a023cc924e Subject: Re: [PATCH v3 0/4] s2mps11 clock driver refactoring To: Andi Shyti , linux-samsung-soc@vger.kernel.org References: <1453284864-8082-1-git-send-email-andi.shyti@samsung.com> Cc: Sangbeom Kim , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Andi Shyti , Yadwinder Singh Brar , Jaehoon Chung From: Krzysztof Kozlowski Message-id: <56A023CC.6@samsung.com> Date: Thu, 21 Jan 2016 09:18:20 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453284864-8082-1-git-send-email-andi.shyti@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrILMWRmVeSWpSXmKPExsVy+t/xa7pnlBeEGZztNrXYfuQZq8XiH8+Z LG78amO1eP3C0OJjzz1Wi8u75rBZzDi/j8ni4ilXi4srvjBZ/DjTzWIx93cjqwO3x/sbrewe l/t6mTyuL/nE7LFz1l12j74tqxg9Pm+SC2CL4rJJSc3JLEst0rdL4Mq4+O8AW8EXropX61Yz NjCu5ehi5OSQEDCRmPzhKCOELSZx4d56ti5GLg4hgaWMErs610E5TxklDk8DcTg4hAVsJLbd iwRpEBHwkpj68ARYs5CAq8STlvnsIPXMAhuYJFbfvM0OkmATMJbYvHwJG4jNK6AicWXnahYQ m0VAVaJx61FmEFtUIELicGcXO0SNoMSPyffAajgF3CQ+zVnCBLKXWUBP4v5FLZAws4C8xOY1 b5knMArMQtIxC6FqFpKqBYzMqxhFU0uTC4qT0nMN9YoTc4tL89L1kvNzNzFCIuLLDsbFx6wO MQpwMCrx8N64Nj9MiDWxrLgy9xCjBAezkgjvV9EFYUK8KYmVValF+fFFpTmpxYcYpTlYlMR5 5+56HyIkkJ5YkpqdmlqQWgSTZeLglGpg3CS0cunEEyeXHdg4U++z0vPwns8FV/TKXsyR0Wlf +nRJ2rJZPtUnF9zyY7yvkHybZ7YN28XXu3bVPTu//M/5cx/z9vQm7heoPbXqQITuG2alhZsj q0+pCIZPrg5b02Gz/Eal8JHjJ07Iv5myyMN12eeeiAe8AbtD2y29itfqMH0tXcAw7/SWc51K LMUZiYZazEXFiQAHl4n2hAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.01.2016 19:14, Andi Shyti wrote: > Hi, > > This patchset contains some code refactoring on the s2mps11 clock > device driver. The main goal is to remove some dead code and > improve its readability. > > At any iteration the patchset is getting a patch more, so that > this time there are four patches :) Which means that if I have more comments now, you will send a v5 with 5 patches inside? Oh... BR, Krzysztof > > Thanks to Krzysztof for his review, the changset is coming from > his suggestions: > > V1 -> V2 > - the order of the patches has changed > - the second patch has been added and it merges a for loop > inside > a previous one > - the 3rd patch (which in the first version was the 1st) > contains some more redundant variables removal. > > V2 -> V3 > - The "merge two for loops in one" has been moved as first patch > - removed the global variable clk_data > > The patches have been applied on next-20160120 and tested on > Odroid Xu4. > > Andi Shyti (4): > clk: s2mps11: merge two for loops in one > clk: s2mps11: allocate only one structure for clock init > clk: s2mps11: remove redundant static variables declaration > clk: s2mps11: remove redundant code > > drivers/clk/clk-s2mps11.c | 108 +++++++++++++--------------------------------- > 1 file changed, 31 insertions(+), 77 deletions(-) >