From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752396AbcAUAfO (ORCPT ); Wed, 20 Jan 2016 19:35:14 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:46279 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752101AbcAUAfL (ORCPT ); Wed, 20 Jan 2016 19:35:11 -0500 X-AuditID: cbfec7f5-f79b16d000005389-61-56a027bd9b76 Subject: Re: [PATCH 1/8] rtc: max77686: Use ARRAY_SIZE() instead of current array length To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1453310088-29985-1-git-send-email-javier@osg.samsung.com> <1453310088-29985-2-git-send-email-javier@osg.samsung.com> Cc: Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Laxman Dewangan , linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56A027BE.4080600@samsung.com> Date: Thu, 21 Jan 2016 09:35:10 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453310088-29985-2-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLLMWRmVeSWpSXmKPExsVy+t/xy7p71ReEGZyYqW7RcW0xk8X1L89Z Ld68XcNk8fqFoUX/49fMFkv3rWaxuLxrDpvFjPP7mCz2d3YwOnB6PNl0kdFjz8STbB6bVnWy efQ2v2Pz2NJ/l92jb8sqRo/Pm+QC2KO4bFJSczLLUov07RK4MuZMfslccIW54vyrY4wNjH+Y uhg5OSQETCQ67txkh7DFJC7cW8/WxcjFISSwlFHiV+syKOcpo8SZDSfYQKqEBaIknvbPZAax RQRCJf5dvM0IUdTMKPHmSQsrSIJZ4B2jxIQ9tiA2m4CxxOblS8CaeQW0JG6d/QBmswioSiw5 +BpstahAhMThzi52iBpBiR+T77F0MXJwcAq4S3x6ZQpiMgvoSdy/qAUxXV5i85q3zBMYBWYh aZiFUDULSdUCRuZVjKKppckFxUnpuUZ6xYm5xaV56XrJ+bmbGCGR8HUH49JjVocYBTgYlXh4 b1ybHybEmlhWXJl7iFGCg1lJhFdOZUGYEG9KYmVValF+fFFpTmrxIUZpDhYlcd6Zu96HCAmk J5akZqemFqQWwWSZODilGhgzzNprQjWm6HspKB2ZpPqaV7Q8zXTO7FfuW0VMJ1j5ZZsXBEyR eF6x1inFInzC4TOvjEzzc28sPOOxbrHby7Cjk2eKVllm1pRN+HBfKsaKhXW2ZcpMI82Utqvl PUqGLLHd+yLNw6S+OC458DfjfYtAxEXNvS4TBWta2JPNVHMqBFoecLj8VWIpzkg01GIuKk4E AFW4wgOAAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.01.2016 02:14, Javier Martinez Canillas wrote: > It is better to use the ARRAY_SIZE() macro instead of the array length > to avoid bugs if the array is later changed and the length not updated. > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/rtc/rtc-max77686.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof