From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751920AbcAUAh3 (ORCPT ); Wed, 20 Jan 2016 19:37:29 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:38331 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbcAUAh0 (ORCPT ); Wed, 20 Jan 2016 19:37:26 -0500 X-AuditID: cbfec7f5-f79b16d000005389-ef-56a02843d02e Subject: Re: [PATCH 2/8] rtc: max77686: Use usleep_range() instead of msleep() To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1453310088-29985-1-git-send-email-javier@osg.samsung.com> <1453310088-29985-3-git-send-email-javier@osg.samsung.com> Cc: Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Laxman Dewangan , linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski Message-id: <56A02845.3010008@samsung.com> Date: Thu, 21 Jan 2016 09:37:25 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453310088-29985-3-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrLLMWRmVeSWpSXmKPExsVy+t/xK7rOGgvCDB5cUrPouLaYyeL6l+es Fm/ermGyeP3C0KL/8Wtmi6X7VrNYXN41h81ixvl9TBb7OzsYHTg9nmy6yOixZ+JJNo9NqzrZ PHqb37F5bOm/y+7Rt2UVo8fnTXIB7FFcNimpOZllqUX6dglcGXPPLGQsOMFW0bfpGWsD42rW LkZODgkBE4nN1+dC2WISF+6tZwOxhQSWMkocWpDSxcgFZD9llJi0awUTSEJYwE/iwfR57CC2 iECoxL+LtxkhipoZJc486QMrYhZ4xygxYY8tiM0mYCyxefkSsKm8AloS7bvegW1jEVCV+LRy LZgtKhAhcbizix2iRlDix+R7LCA2p4C7xIMFncxdjBxAM/Uk7l/UghgvL7F5zVvmCYwCs5B0 zEKomoWkagEj8ypG0dTS5ILipPRcI73ixNzi0rx0veT83E2MkEj4uoNx6TGrQ4wCHIxKPLw3 rs0PE2JNLCuuzD3EKMHBrCTCK6eyIEyINyWxsiq1KD++qDQntfgQozQHi5I478xd70OEBNIT S1KzU1MLUotgskwcnFINjKdYEnft2ftBkYH/+3urHt7H3PcdMyWXC3HcjOORMd/Ofe+cpnXM 78ptInfX3/62JkxqNlv3DY9lH7r7t9e6bHnnf+Lj1NcZk1IcMjRP6uqnbfjD3ndGe8GJT/Il tjnCT+88VlJe1jMj6Wi3otpPq5yG7ndF/27VNakXa+ft7VHh8jkRzCDLpcRSnJFoqMVcVJwI AD80s8SAAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.01.2016 02:14, Javier Martinez Canillas wrote: > Documentation/timers/timers-howto.txt suggest to use usleep_range() > instead of msleep() for small msec (1ms - 20ms) since msleep() will > often sleep for 20ms for any value in that range. > > This is fine in this case since 16ms is the _minimum_ delay required > by max77686 for an RTC update but by using usleep_range() instead of > msleep(), the driver can support other RTC IP blocks with a shorter > minium delay (i.e: in the range of usecs insted of msecs). s/minium/minimum/ s/insted/instead/ > > Signed-off-by: Javier Martinez Canillas > --- > > drivers/rtc/rtc-max77686.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof