From: Vlastimil Babka <vbabka@suse.cz>
To: "Mario Kleiner" <mario.kleiner.de@gmail.com>,
"Michel Dänzer" <michel@daenzer.net>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
LKML <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org, mgraesslin@kde.org,
kwin@kde.org, "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon
Date: Thu, 21 Jan 2016 10:15:52 +0100 [thread overview]
Message-ID: <56A0A1C8.40207@suse.cz> (raw)
In-Reply-To: <56A096B1.4060203@gmail.com>
On 01/21/2016 09:28 AM, Mario Kleiner wrote:
>> ... just like drm_vblank_pre/post_modeset. That those were broken is a
>> regression which needs to be fixed anyway. I don't think switching to
>> drm_vblank_on/off is suitable for stable trees.
>>
>> Looking at Vlastimil's original post again, I'd say the most likely
>> culprit is 4dfd6486 ("drm: Use vblank timestamps to guesstimate how many
>> vblanks were missed").
>>
Yeah, this is what I bisected to.
> Yes, i think reverting that one alone would likely fix it by reverting
> to the old vblank update logic.
Yep I said in the original mail that reverting on top of 4.4 fixed it.
Well not just this single commit, but also some patches on top (e.g.
radeon and amdgpu adaptations to that commit, IIRC it wouldn't have
compiled otherwise).
>>
>>> Once drm_vblank_off is called, drm_vblank_get will no-op and return an
>>> error, so clients can't enable vblank irqs during the modeset - pageflip
>>> ioctl and waitvblank ioctl would fail while a modeset happens -
>>> hopefully userspace handles this correctly everywhere.
>>
>> We've fixed xf86-video-ati for this.
>>
>>
>>> I'll hack up a patch for demonstration now.
>>
>> You're a bit late to that party. :)
>>
>> http://lists.freedesktop.org/archives/dri-devel/2015-May/083614.html
>> http://lists.freedesktop.org/archives/dri-devel/2015-July/086451.html
>>
>>
>
> Oops. Just sent out my little (so far untested) creations. Yes, they are
> essentially the same as Daniel's patches. The only addition is to also
> fix that other potential small race i describe by slightly moving the
> xxx_pm_compute_clocks() calls around. And a fix for drm_vblank_get/put
> imbalance in radeon_pm if vblank_on/off would be used.
Thanks, I'll test.
>
> -mario
>
prev parent reply other threads:[~2016-01-21 9:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 10:34 Vlastimil Babka
2016-01-15 12:26 ` Ville Syrjälä
2016-01-15 12:40 ` Vlastimil Babka
2016-01-16 4:24 ` Mario Kleiner
2016-01-18 10:49 ` Vlastimil Babka
2016-01-18 14:06 ` Vlastimil Babka
2016-01-18 14:14 ` Christian König
2016-01-20 20:25 ` Vlastimil Babka
2016-01-20 20:32 ` Mario Kleiner
2016-01-21 3:43 ` Michel Dänzer
2016-01-21 5:31 ` Mario Kleiner
2016-01-21 6:38 ` Michel Dänzer
2016-01-21 6:41 ` Michel Dänzer
2016-01-21 7:58 ` Daniel Vetter
2016-01-21 8:36 ` Michel Dänzer
2016-01-21 10:09 ` Daniel Vetter
2016-01-22 3:06 ` Michel Dänzer
2016-01-22 15:18 ` Ville Syrjälä
2016-01-22 18:29 ` Mario Kleiner
2016-01-23 18:23 ` Mario Kleiner
2016-01-25 4:15 ` Michel Dänzer
2016-01-25 13:16 ` Mario Kleiner
2016-01-25 13:23 ` Ville Syrjälä
2016-01-25 13:44 ` Mario Kleiner
2016-01-25 14:53 ` Ville Syrjälä
2016-01-25 16:38 ` Mario Kleiner
2016-01-25 18:51 ` Daniel Vetter
2016-01-25 19:30 ` Mario Kleiner
2016-01-25 20:32 ` Daniel Vetter
2016-01-25 21:42 ` Mario Kleiner
2016-01-25 22:05 ` Daniel Vetter
2016-01-21 8:28 ` Mario Kleiner
2016-01-21 9:15 ` Vlastimil Babka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A0A1C8.40207@suse.cz \
--to=vbabka@suse.cz \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kwin@kde.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.kleiner.de@gmail.com \
--cc=mgraesslin@kde.org \
--cc=michel@daenzer.net \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome