From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759586AbcAUOEa (ORCPT ); Thu, 21 Jan 2016 09:04:30 -0500 Received: from lists.s-osg.org ([54.187.51.154]:32922 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759002AbcAUOE1 (ORCPT ); Thu, 21 Jan 2016 09:04:27 -0500 Subject: Re: question about samsung/sxgbe/sxgbe_xpcs.c To: =?UTF-8?Q?J=ce=b5an_Sacren?= , David Miller , siva.kallam@broadcom.com References: <20160119.143628.432983847877790677.davem@davemloft.net> <20160121051056.GA4373@mail.gmail.com> Cc: julia.lawall@lip6.fr, shuahkhan@gmail.com, bh74.an@samsung.com, ks.giri@samsung.com, vipul.pandya@samsung.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Shuah Khan X-Enigmail-Draft-Status: N1110 Organization: Samsung Open Source Group Message-ID: <56A0E561.2030409@osg.samsung.com> Date: Thu, 21 Jan 2016 07:04:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160121051056.GA4373@mail.gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/20/2016 10:10 PM, Jεan Sacren wrote: > From: David Miller > Date: Tue, 19 Jan 2016 14:36:28 -0500 >> >> From: Julia Lawall >> Date: Tue, 19 Jan 2016 19:54:20 +0100 (CET) > > [...] > >>> I just wondered. I was looking at dependencies between networking files. >>> This one stands out because nothing is dependenton it, even the files it >>> is compiled with, and it doesn't contain the usual functions, >>> register_netdev, etc. >> >> Even with that explanation, this is a bogus situation. >> >> There are no in-tree callers of this code. It should be removed until there >> are in-tree users. >> >> Nobody can figure out if the interface for this is done properly without seeing >> the call sites and how they work. It is therefore impossible to review this >> code and judge it's design. >> >> If someone doesn't send me a removal patch, I will remove this code myself. > > I have the patch ready. > > Do you want me to submit it now during the merge window or wait till > net-next opens up again? > My second attempt to locate the author for a comment on this before it gets removed. Maybe this code could be fixed just in case it is important for some product out there. I am cc'ing the original author in case he has any comments. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978