mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrey Ryabinin <aryabinin@virtuozzo.com>
To: Dave Jones <davej@codemonkey.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: UBSAN: run-time undefined behavior sanity checker
Date: Fri, 22 Jan 2016 19:43:55 +0300	[thread overview]
Message-ID: <56A25C4B.2000204@virtuozzo.com> (raw)
In-Reply-To: <20160122051539.GA1326@codemonkey.org.uk>

On 01/22/2016 08:15 AM, Dave Jones wrote:
> On Thu, Jan 21, 2016 at 08:57:17PM +0000, Linux Kernel wrote:
>  > Web:        https://git.kernel.org/torvalds/c/c6d308534aef6c99904bf5862066360ae067abc4
>  > Commit:     c6d308534aef6c99904bf5862066360ae067abc4
>  > Parent:     68920c973254c5b71a684645c5f6f82d6732c5d6
>  > Refname:    refs/heads/master
>  > Author:     Andrey Ryabinin <aryabinin@virtuozzo.com>
>  > AuthorDate: Wed Jan 20 15:00:55 2016 -0800
>  > Committer:  Linus Torvalds <torvalds@linux-foundation.org>
>  > CommitDate: Wed Jan 20 17:09:18 2016 -0800
>  > 
>  >     UBSAN: run-time undefined behavior sanity checker
>  >     
>  >     UBSAN uses compile-time instrumentation to catch undefined behavior
>  >     (UB).  Compiler inserts code that perform certain kinds of checks before
>  >     operations that could cause UB.  If check fails (i.e.  UB detected)
>  >     __ubsan_handle_* function called to print error message.
>  >     
>  >     So the most of the work is done by compiler.  This patch just implements
>  >     ubsan handlers printing errors.
>  >     
>  >     GCC has this capability since 4.9.x [1] (see -fsanitize=undefined
>  >     option and its suboptions).
>  >     However GCC 5.x has more checkers implemented [2].
>  >     Article [3] has a bit more details about UBSAN in the GCC.
> 
> If I enable this and CONFIG_UBSAN_ALIGNMENT, the kernel doesn't boot,
> and hangs really early (pretty much as soon as I hit return in grub)
> far too early for serial console or even tty output.
> 
> Compiler is debian unstable's 5.3.1 20160114
> 
> I don't know if this is worth chasing down, I chose to just disable it,
> but figured I'd post in case other people stumble across the same issue.
> 

Likely caused by unaligned access in very early code, which ends up in too early printk() call.
You could try to disable instrumentation (UBSAN_SANITIZE := n) in early code.

Be aware that CONFIG_UBSAN_ALIGNMENT causes a *lot* of spam in dmesg. Since x86 supports unaligned
accesses, the significant amount of that spam just a false-positive reports.

  reply	other threads:[~2016-01-22 16:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20160121205717.AF61F661293@gitolite.kernel.org>
2016-01-22  5:15 ` Dave Jones
2016-01-22 16:43   ` Andrey Ryabinin [this message]
2016-01-22 17:00     ` Dave Jones
2016-01-25 14:03       ` Andrey Ryabinin
     [not found]         ` <20160126165322.GA24364@codemonkey.org.uk>
2016-02-01 16:08           ` Andrey Ryabinin
2016-02-01 22:18             ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A25C4B.2000204@virtuozzo.com \
    --to=aryabinin@virtuozzo.com \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome