From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <tom.leiming@gmail.com>, linux-kernel@vger.kernel.org
Cc: linux-block@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Stefan Haberland <sth@linux.vnet.ibm.com>,
Keith Busch <keith.busch@intel.com>
Subject: Re: [PATCH v1] block: fix bio splitting on max sectors
Date: Fri, 22 Jan 2016 20:44:14 -0700 [thread overview]
Message-ID: <56A2F70E.2070802@kernel.dk> (raw)
In-Reply-To: <1453507533-25593-1-git-send-email-tom.leiming@gmail.com>
On 01/22/2016 05:05 PM, Ming Lei wrote:
> After commit e36f62042880(block: split bios to maxpossible length),
> bio can be splitted in the middle of a vector entry, then it
> is easy to split out one bio which size isn't aligned with block
> size, especially when the block size is bigger than 512.
>
> This patch fixes the issue by making the max io size aligned
> to logical block size.
>
> Fixes: e36f62042880(block: split bios to maxpossible length)
> Reported-by: Stefan Haberland <sth@linux.vnet.ibm.com>
> Cc: Keith Busch <keith.busch@intel.com>
> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
> V1:
> - avoid double shift as suggested by Linus
> - compute 'max_sectors' once as suggested by Keith
This looks good to me, I'll apply and run a bit of local testing.
--
Jens Axboe
next prev parent reply other threads:[~2016-01-23 3:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-23 0:05 Ming Lei
2016-01-23 3:44 ` Jens Axboe [this message]
2016-01-25 14:13 ` Stefan Haberland
2016-01-25 18:27 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A2F70E.2070802@kernel.dk \
--to=axboe@kernel.dk \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sth@linux.vnet.ibm.com \
--cc=tom.leiming@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome