From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755266AbcAYE6h (ORCPT ); Sun, 24 Jan 2016 23:58:37 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:39247 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754411AbcAYE6e (ORCPT ); Sun, 24 Jan 2016 23:58:34 -0500 X-AuditID: cbfee68d-f79646d000001355-df-56a5ab78822a Message-id: <56A5AB78.5020706@samsung.com> Date: Mon, 25 Jan 2016 13:58:32 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Shawn Lin , Ulf Hansson Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: dw_mmc: fix err handle of dw_mci_probe References: <1453448592-9897-1-git-send-email-shawn.lin@rock-chips.com> In-reply-to: <1453448592-9897-1-git-send-email-shawn.lin@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42JZI2JSrFuxemmYQdsBUYvLu+awWRz5389o cefJelaL42vDHVg87lzbw+bxd9Z+Fo/Pm+QCmKO4bFJSczLLUov07RK4Mo7/nc1YsJS94teN I2wNjG9Yuxg5OSQETCSWzbzCBmGLSVy4tx7MFhJYwSixcp8UTM3JnbOYuxi5gOKzGCWuPpnN AuE8YJT40LiCCaSKV0BLorVhHdhUFgFVic8H1oBNYhPQkdj+7ThYjahAmMSDdXtZIeoFJX5M vscCYosI+Els3bEVrJ5ZwFri549WsBphAQeJtTfuskJc5C7xsOEiexcjBwengIfE4hlJICaz gJ7E/YtaEJ3yEpvXvGWGuHkVu8SnBzEQ1whIfJt8iAWkXEJAVmLTAagSSYmDK26wTGAUm4Xk nlkIQ2chGbqAkXkVo2hqQXJBcVJ6kaFecWJucWleul5yfu4mRmDsnP73rHcH4+0D1ocYBTgY lXh4LdSWhgmxJpYVV+YeYjQFOmIis5Rocj4wQvNK4g2NzYwsTE1MjY3MLc2UxHkVpX4GCwmk J5akZqemFqQWxReV5qQWH2Jk4uCUamAUYwm7eDxmx+S03SGNVz47nl8TXXdwVtOPNVpLua/u Pps/+zzX7OxHL+ZPCDG59L+vVmON1HrXwJZZwR1Hi2/cCnrZHvNO0rnk95X3xldkfrQteHXn TgTz4Qcp55t8LnOcOTkp6RZ/q1wvK7v0o8J1Uy4eZ9pS+S5t7w5hmaKaLbpxU67r8dw3VWIp zkg01GIuKk4EAK7l0RSYAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsVy+t9jQd2K1UvDDGZMF7S4vGsOm8WR//2M FneerGe1OL423IHF4861PWwef2ftZ/H4vEkugDmqgdEmIzUxJbVIITUvOT8lMy/dVsk7ON45 3tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB2ibkkJZYk4pUCggsbhYSd8O04TQEDddC5jGCF3f kCC4HiMDNJCwhjHj+N/ZjAVL2St+3TjC1sD4hrWLkZNDQsBE4uTOWcwQtpjEhXvr2boYuTiE BGYxSlx9MpsFwnnAKPGhcQUTSBWvgJZEa8M6sG4WAVWJzwfWsIHYbAI6Etu/HQerERUIk3iw bi8rRL2gxI/J91hAbBEBP4mtO7aC1TMLWEv8/NEKViMs4CCx9sZdMFtIwF3iYcNF9i5GDg5O AQ+JxTOSQExmAT2J+xe1IDrlJTavecs8gRHoSIQFsxCqZiGpWsDIvIpRIrUguaA4KT3XKC+1 XK84Mbe4NC9dLzk/dxMjOEafSe9gPLzL/RCjAAejEg+vhdrSMCHWxLLiytxDjBIczEoivH8X AoV4UxIrq1KL8uOLSnNSiw8xmgJDYCKzlGhyPjB95JXEGxqbmBlZGpkbWhgZmyuJ8+67FBkm JJCeWJKanZpakFoE08fEwSnVwHiY9Th7sGXmwd7oP96ej/47fLVtiV2xzjRwM9/RWces2PIt DEOEnpuFvk3csSBpuZ98Uui/OPbFL2r55jYrbldeHe9U+K9lPX+RbMybF0mFDUFHHxzWPuyU nMrmzXh94dSy8kd5acd8LQwmdgXLFm6WdTpmeWlTRFSFa9ejrzZ/Yv2uiZ36rcRSnJFoqMVc VJwIAIP+PGjnAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Shawn. On 01/22/2016 04:43 PM, Shawn Lin wrote: > This patch add correct err handle if dw_mci_ctrl_reset > failed while probing. Thanks! I will applied this. Best Regards, Jaehoon Chung > > Signed-off-by: Shawn Lin > --- > > drivers/mmc/host/dw_mmc.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 065a8f5..ec19984 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -3046,8 +3046,10 @@ int dw_mci_probe(struct dw_mci *host) > } > > /* Reset all blocks */ > - if (!dw_mci_ctrl_reset(host, SDMMC_CTRL_ALL_RESET_FLAGS)) > - return -ENODEV; > + if (!dw_mci_ctrl_reset(host, SDMMC_CTRL_ALL_RESET_FLAGS)) { > + ret = -ENODEV; > + goto err_clk_ciu; > + } > > host->dma_ops = host->pdata->dma_ops; > dw_mci_init_dma(host); >