From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755972AbcAYJMV (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Jan 2016 04:12:21 -0500
Received: from mailout2.w1.samsung.com ([210.118.77.12]:60354 "EHLO
	mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755584AbcAYJKj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jan 2016 04:10:39 -0500
X-AuditID: cbfec7f4-f79026d00000418a-e9-56a5e68c8fdd
Subject: Re: [RESEND v2 1/2] clk: samsung: Don't build ARMv8 clock drivers on
 ARMv7
To: Arnd Bergmann <arnd@arndb.de>
References: <1453683021-6998-1-git-send-email-k.kozlowski@samsung.com>
 <1453683021-6998-2-git-send-email-k.kozlowski@samsung.com>
 <4282078.QlIpNj3Oa6@wuerfel>
Cc: Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
        linux-clk@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>, Kukjin Kim <kgene@kernel.org>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Tomasz Figa <tomasz.figa@gmail.com>, Olof Johansson <olof@lixom.net>,
        linux-arm-kernel@lists.infradead.org,
        Kevin Hilman <khilman@kernel.org>
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <56A5E687.3060209@samsung.com>
Date: Mon, 25 Jan 2016 18:10:31 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-version: 1.0
In-reply-to: <4282078.QlIpNj3Oa6@wuerfel>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsVy+t/xa7o9z5aGGXR0SVr8nXSM3eL9sh5G
	i/lHzrFavH5haNH/+DWzxdPNj5ksNj2+xmrxseceq8XlXXPYLGac38dkcfGUq8Wp65/ZLA6/
	aWe1+HGmm8Vi1a4/jBYvP55gcRDwWDNvDaPH71+TGD3e32hl97jc18vksXPWXXaPTas62Tw2
	L6n3uHKiidWjb8sqRo/Pm+QCuKK4bFJSczLLUov07RK4Mk7dvsJY8JCjonPxX8YGxu9sXYwc
	HBICJhKXJ6Z0MXICmWISF+6tBwpzcQgJLGWU2L3zGhOE85RR4uDHD4wgVcICoRIT9i1kBbFF
	BBQlpr54xgxRtIhRYs9fiA5mgWYWiX3fzrODVLEJGEtsXr6EDcTmFdCSuD7hJivIahYBVYm5
	j5lBwqICERKHO7vYIUoEJX5MvscCYnMKaEqsfH6EHaScWUBP4v5FLZAws4C8xOY1b5knMArM
	QtIxC6FqFpKqBYzMqxhFU0uTC4qT0nMN9YoTc4tL89L1kvNzNzFCIu3LDsbFx6wOMQpwMCrx
	8FqoLQ0TYk0sK67MPcQowcGsJMI74QFQiDclsbIqtSg/vqg0J7X4EKM0B4uSOO/cXe9DhATS
	E0tSs1NTC1KLYLJMHJxSDYzz5DP6LF0CxM7/62vYf+Olnl5xVpHN/XeT8wNdYwr57+f6TPyn
	HCasPt/2q9/MxgltCtfrruenztNT+X3AiSMg9/61yCfrfdhOf9gdtMSGKTN15Z4AMYc7e77s
	eSq3J7lEP+/gL4HEV4unTzbfV3JGx4n/QUpB+AaH5F77fo/QQDmet5lNf5RYijMSDbWYi4oT
	AYh7f+OwAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25.01.2016 17:59, Arnd Bergmann wrote:
> On Monday 25 January 2016 09:50:20 Krzysztof Kozlowski wrote:
>>
>> +# ARM64 SoCs (e.g. Exynos5433, Exynos7):
>> +config EXYNOS_ARM64_COMMON_CLK
>> +       def_bool ARCH_EXYNOS
>> +       depends on ARM64 || COMPILE_TEST
>> +       select COMMON_CLK_SAMSUNG
>>
> 
> So you always enable it on ARM64 when ARCH_EXYNOS is enabled, but
> enable it silently on ARM32 when COMPILE_TEST is set?

Hmm... indeed it would better to make it toggle-able when COMPILE_TEST.

> That sounds wrong. How about
> 
> config EXYNOS_ARM64_COMMON_CLK
> 	bool "EXYNOS 64-bit clock support" if COMPILE_TEST
> 	default ARM64 && ARCH_EXYNOS
> 	depends on (ARM64 && ARCH_EXYNOS) || COMPILE_TEST
> 	select COMMON_CLK_SAMSUNG

Although this looks more complicated but it does the trick. Thanks for
the hint. Only one (not related directly to this change) issue - with
COMPILE_TEST the "EXYNOS 64-bit clock support" option goes above the
common clock framework (up to drivers section) because it is not part of
the Clocks menu. I'll fix it in v3.

Best regards,
Krzysztof